Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable cat for cuda bits types #115044

Closed
wants to merge 10 commits into from
Closed

enable cat for cuda bits types #115044

wants to merge 10 commits into from
+71 −18

Conversation

ngimel
Copy link
Collaborator

@ngimel ngimel commented Dec 3, 2023

It was already working for cpu, so bring parity.
Also, slightly reduce number of compiled kernels by using OpaqueType.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 3, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115044

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 157c7a5 with merge base 4cfe997 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Dec 3, 2023
@ngimel ngimel requested a review from malfet December 3, 2023 22:47
@vadimkantorov vadimkantorov mentioned this pull request Dec 4, 2023
Open
malfet
malfet approved these changes Dec 5, 2023
View reviewed changes
test/test_quantization.py
@@ -153,7 +153,14 @@
logging.warning(e)

# Experimental functionality
from quantization.core.experimental.test_bits import TestBits # noqa: F401
try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes Steve sad...

aten/src/ATen/native/cuda/Shape.cu Outdated Show resolved Hide resolved
aten/src/ATen/native/cuda/Shape.cu Show resolved Hide resolved
aten/src/ATen/native/cuda/Shape.cu Outdated Show resolved Hide resolved
@malfet malfet added the topic: improvements topic category label Dec 5, 2023
@malfet
Copy link
Contributor

malfet commented Dec 5, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 5, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ngimel and others added 3 commits December 4, 2023 20:31
@ngimel @malfet
Update aten/src/ATen/native/cuda/Shape.cu
7968588 
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
@ngimel @malfet
Update aten/src/ATen/native/cuda/Shape.cu
fbe7e5e 
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
@ngimel @malfet
Update aten/src/ATen/native/cuda/Shape.cu
d7c7aed 
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

ngimel
ngimel commented Dec 5, 2023
View reviewed changes
aten/src/ATen/native/cuda/Shape.cu Outdated Show resolved Hide resolved
aten/src/ATen/native/cuda/Shape.cu Outdated Show resolved Hide resolved
@ngimel
Copy link
Collaborator Author

ngimel commented Dec 5, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor

malfet commented Dec 5, 2023

@pytorchbot revert -m "This breaks ROCM" -c nosignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@ngimel your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Dec 5, 2023
@pytorchmergebot
Revert "enable cat for cuda bits types (#115044)"
063423e 
This reverts commit 4cf97c4.

Reverted #115044 on behalf of https://github.com/malfet due to This breaks ROCM ([comment](#115044 (comment)))
@ngimel
Copy link
Collaborator Author

ngimel commented Dec 6, 2023

@pytorchbot merge -f "flaky test"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kit1980 kit1980 removed the Reverted label Dec 21, 2023
hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request Dec 21, 2023
@ngimel @hyperfraise
enable cat for cuda bits types (pytorch#115044)
5d43b36 
It was already working for cpu, so bring parity.
Also, slightly reduce number of compiled kernels by using OpaqueType.

Pull Request resolved: pytorch#115044
Approved by: https://github.com/malfet
hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request Dec 21, 2023
@pytorchmergebot @hyperfraise
Revert "enable cat for cuda bits types (pytorch#115044)"
ccd3a73 
This reverts commit 4cf97c4.

Reverted pytorch#115044 on behalf of https://github.com/malfet due to This breaks ROCM ([comment](pytorch#115044 (comment)))
hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request Dec 21, 2023
@ngimel @hyperfraise
enable cat for cuda bits types (pytorch#115044)
b935bf8 
It was already working for cpu, so bring parity.
Also, slightly reduce number of compiled kernels by using OpaqueType.

Pull Request resolved: pytorch#115044
Approved by: https://github.com/malfet
hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request Dec 21, 2023
@ngimel @hyperfraise
enable cat for cuda bits types (pytorch#115044)
146c698 
It was already working for cpu, so bring parity.
Also, slightly reduce number of compiled kernels by using OpaqueType.

Pull Request resolved: pytorch#115044
Approved by: https://github.com/malfet
hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request Dec 21, 2023
@pytorchmergebot @hyperfraise
Revert "enable cat for cuda bits types (pytorch#115044)"
3b1cfd5 
This reverts commit 4cf97c4.

Reverted pytorch#115044 on behalf of https://github.com/malfet due to This breaks ROCM ([comment](pytorch#115044 (comment)))
hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request Dec 21, 2023
@ngimel @hyperfraise
enable cat for cuda bits types (pytorch#115044)
88ee429 
It was already working for cpu, so bring parity.
Also, slightly reduce number of compiled kernels by using OpaqueType.

Pull Request resolved: pytorch#115044
Approved by: https://github.com/malfet
ZhiweiYan-96 pushed a commit to ZhiweiYan-96/pytorch that referenced this pull request Dec 22, 2023
@ngimel @ZhiweiYan-96
enable cat for cuda bits types (pytorch#115044)
e95e266 
It was already working for cpu, so bring parity.
Also, slightly reduce number of compiled kernels by using OpaqueType.

Pull Request resolved: pytorch#115044
Approved by: https://github.com/malfet
ZhiweiYan-96 pushed a commit to ZhiweiYan-96/pytorch that referenced this pull request Dec 22, 2023
@pytorchmergebot @ZhiweiYan-96
Revert "enable cat for cuda bits types (pytorch#115044)"
5f6d952 
This reverts commit 4cf97c4.

Reverted pytorch#115044 on behalf of https://github.com/malfet due to This breaks ROCM ([comment](pytorch#115044 (comment)))
ZhiweiYan-96 pushed a commit to ZhiweiYan-96/pytorch that referenced this pull request Dec 22, 2023
@ngimel @ZhiweiYan-96
enable cat for cuda bits types (pytorch#115044)
917c724 
It was already working for cpu, so bring parity.
Also, slightly reduce number of compiled kernels by using OpaqueType.

Pull Request resolved: pytorch#115044
Approved by: https://github.com/malfet
@github-actions github-actions bot deleted the ngimel/ups_cat_bits branch February 19, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168 jerryzh168 is a code owner

Assignees
No one assigned
Labels
ciflow/rocm ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: quantization release notes category topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ngimel @malfet @pytorchmergebot @kit1980 @pytorchbot