Fix NULL dereference in binary CPU ops #115183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Targeted fix for #113037 A more fundamental one, where those functions are not even called for empty tensors are coming later
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115183
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5ea91b0 with merge base 7843df6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
added
the
module: cpu
drisspg
approved these changes
Dec 5, 2023
atalman
approved these changes
Dec 5, 2023
huydhn
approved these changes
Dec 5, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
malfet
added
topic: bug fixes
Merge failedReason: 4 mandatory check(s) failed. The first few are:
Dig deeper by viewing the failures on hud |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / test (default, 2, 3, macos-m1-12) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
huydhn
pushed a commit
that referenced
this pull request
Dec 6, 2023
Targeted fix for #113037 A more fundamental one, where those functions are not even called for empty tensors are coming later Pull Request resolved: #115183 Approved by: https://github.com/drisspg, https://github.com/atalman, https://github.com/huydhn
huydhn
pushed a commit
that referenced
this pull request
Dec 6, 2023
Targeted fix for #113037 A more fundamental one, where those functions are not even called for empty tensors are coming later Pull Request resolved: #115183 Approved by: https://github.com/drisspg, https://github.com/atalman, https://github.com/huydhn
This was referenced Dec 6, 2023
huydhn
added a commit
that referenced
this pull request
Dec 6, 2023
* Fix NULL dereference in binary CPU ops (#115183) Targeted fix for #113037 A more fundamental one, where those functions are not even called for empty tensors are coming later Pull Request resolved: #115183 Approved by: https://github.com/drisspg, https://github.com/atalman, https://github.com/huydhn * Fix build after conflict resolution * Also include #113262 to pass the test --------- Co-authored-by: Nikita Shulga <nshulga@meta.com>
This was referenced Dec 9, 2023
malfet
added a commit
that referenced
this pull request
Dec 9, 2023
malfet
added a commit
that referenced
this pull request
Dec 9, 2023
malfet
added a commit
that referenced
this pull request
Dec 9, 2023
hyperfraise
pushed a commit
to hyperfraise/pytorch
that referenced
this pull request
Dec 21, 2023
Targeted fix for pytorch#113037 A more fundamental one, where those functions are not even called for empty tensors are coming later Pull Request resolved: pytorch#115183 Approved by: https://github.com/drisspg, https://github.com/atalman, https://github.com/huydhn
hyperfraise
pushed a commit
to hyperfraise/pytorch
that referenced
this pull request
Dec 21, 2023
Targeted fix for pytorch#113037 A more fundamental one, where those functions are not even called for empty tensors are coming later Pull Request resolved: pytorch#115183 Approved by: https://github.com/drisspg, https://github.com/atalman, https://github.com/huydhn
ZhiweiYan-96
pushed a commit
to ZhiweiYan-96/pytorch
that referenced
this pull request
Dec 22, 2023
Targeted fix for pytorch#113037 A more fundamental one, where those functions are not even called for empty tensors are coming later Pull Request resolved: pytorch#115183 Approved by: https://github.com/drisspg, https://github.com/atalman, https://github.com/huydhn
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted fix for #113037
A more fundamental one, where those functions are not even called for
empty tensors are coming later
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10