Fix missing dependency in torch.utils.tensorboard #115598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115598
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit ba27f5a with merge base 617c228 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Didn't find following labels among repository labels: release notes: fix missing import from torch.utils.tensorboard |
|
@pytorchbot label "release notes: fx" |
malfet
requested changes
Dec 12, 2023
|
@malfet Yes, you're right, my mistake! Thanks! |
soulitzer
added
the
triaged
|
@malfet @soulitzer Are we happy to merge this ? |
malfet
approved these changes
Dec 20, 2023
|
@pytorchbot merge -f "It's not tested anyway" |
malfet
added
release notes: profiler
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
hyperfraise
pushed a commit
to hyperfraise/pytorch
that referenced
this pull request
Dec 21, 2023
Fixes pytorch#114591 Version package was removed in this pull request: pytorch#114108 but is still used in `torch.utils.tensorboard` causing import errors. The fix removes the import and uses a simpler check. Pull Request resolved: pytorch#115598 Approved by: https://github.com/malfet
hyperfraise
pushed a commit
to hyperfraise/pytorch
that referenced
this pull request
Dec 21, 2023
Fixes pytorch#114591 Version package was removed in this pull request: pytorch#114108 but is still used in `torch.utils.tensorboard` causing import errors. The fix removes the import and uses a simpler check. Pull Request resolved: pytorch#115598 Approved by: https://github.com/malfet
ZhiweiYan-96
pushed a commit
to ZhiweiYan-96/pytorch
that referenced
this pull request
Dec 22, 2023
Fixes pytorch#114591 Version package was removed in this pull request: pytorch#114108 but is still used in `torch.utils.tensorboard` causing import errors. The fix removes the import and uses a simpler check. Pull Request resolved: pytorch#115598 Approved by: https://github.com/malfet
atalman
pushed a commit
to atalman/pytorch
that referenced
this pull request
Dec 28, 2023
Fixes pytorch#114591 Version package was removed in this pull request: pytorch#114108 but is still used in `torch.utils.tensorboard` causing import errors. The fix removes the import and uses a simpler check. Pull Request resolved: pytorch#115598 Approved by: https://github.com/malfet
atalman
added a commit
that referenced
this pull request
Dec 28, 2023
Fixes #114591 Version package was removed in this pull request: #114108 but is still used in `torch.utils.tensorboard` causing import errors. The fix removes the import and uses a simpler check. Pull Request resolved: #115598 Approved by: https://github.com/malfet Co-authored-by: Sacha <sachahu@hotmail.fr>
11 tasks
|
Validated via: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114591
Version package was removed in this pull request: #114108 but is still used in
torch.utils.tensorboardcausing import errors. The fix removes the import and uses a simpler check.