Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C10D] Make all PGNCCL LOG usages use logPrefix() #116060

Closed
wants to merge 6 commits into from

Conversation

Copy link

pytorch-bot bot commented Dec 18, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116060

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit 68db002 with merge base 1474eb5 (image):

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

wconstab added a commit that referenced this pull request Dec 18, 2023
ghstack-source-id: 3aff3612af6a7ed05c7d3b4525ec93fb2039b84a
Pull Request resolved: #116060
@github-actions github-actions bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Dec 18, 2023
wconstab added a commit that referenced this pull request Dec 18, 2023
ghstack-source-id: aff9efeb6d877f9bde726a2288dfa961ee714f0c
Pull Request resolved: #116060
wconstab added a commit that referenced this pull request Dec 19, 2023
ghstack-source-id: d4035cb7d91940165de596831deea1f62011be25
Pull Request resolved: #116060
wconstab added a commit that referenced this pull request Dec 19, 2023
ghstack-source-id: d4035cb7d91940165de596831deea1f62011be25
Pull Request resolved: #116060
wconstab added a commit that referenced this pull request Dec 19, 2023
ghstack-source-id: 9f7aa422ac9165937c71739026edd281d36b3964
Pull Request resolved: #116060
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wconstab added a commit that referenced this pull request Dec 19, 2023
ghstack-source-id: 4d89b561a68c3bc7610a54ca94305790032697e9
Pull Request resolved: #116060
@wconstab
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 20, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@wconstab wconstab deleted the gh/wconstab/253/head branch December 20, 2023 04:23
hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request Dec 21, 2023
hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request Dec 21, 2023
ZhiweiYan-96 pushed a commit to ZhiweiYan-96/pytorch that referenced this pull request Dec 22, 2023
wconstab added a commit that referenced this pull request Jan 26, 2024
wconstab added a commit that referenced this pull request Jan 26, 2024
wconstab added a commit that referenced this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants