New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C10D] Make all PGNCCL LOG usages use logPrefix() #116060
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116060
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 68db002 with merge base 1474eb5 (): UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: 3aff3612af6a7ed05c7d3b4525ec93fb2039b84a Pull Request resolved: #116060
[ghstack-poisoned]
ghstack-source-id: aff9efeb6d877f9bde726a2288dfa961ee714f0c Pull Request resolved: #116060
[ghstack-poisoned]
ghstack-source-id: d4035cb7d91940165de596831deea1f62011be25 Pull Request resolved: #116060
[ghstack-poisoned]
ghstack-source-id: d4035cb7d91940165de596831deea1f62011be25 Pull Request resolved: #116060
[ghstack-poisoned]
ghstack-source-id: 9f7aa422ac9165937c71739026edd281d36b3964 Pull Request resolved: #116060
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[ghstack-poisoned]
ghstack-source-id: 4d89b561a68c3bc7610a54ca94305790032697e9 Pull Request resolved: #116060
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Pull Request resolved: pytorch#116060 Approved by: https://github.com/fduwjj ghstack dependencies: pytorch#116059
Pull Request resolved: pytorch#116060 Approved by: https://github.com/fduwjj ghstack dependencies: pytorch#116059
Pull Request resolved: pytorch#116060 Approved by: https://github.com/fduwjj ghstack dependencies: pytorch#116059
Pull Request resolved: #116060 Approved by: https://github.com/fduwjj ghstack dependencies: #116059
Pull Request resolved: #116060 Approved by: https://github.com/fduwjj ghstack dependencies: #116059
Pull Request resolved: #116060 Approved by: https://github.com/fduwjj ghstack dependencies: #116059
Stack from ghstack (oldest at bottom):
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @yf225