[Dynamo][10/N] Remove TorchVariable and is_allowed #116312
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116312
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6a95351 with merge base ad3c0b2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
added
oncall: distributed
yanboliang
changed the title
|
@pytorchbot successfully started a revert job. Check the current status here. |
Reverting PR 116312 failedReason: Command Details for Dev Infra teamRaised by workflow job |
…actor (#116365)" This reverts commit 951da38. Reverted #116365 on behalf of https://github.com/kit1980 due to Need to revert this because of #116312 ([comment](#116365 (comment)))
…116365) Fixes #ISSUE_NUMBER Pull Request resolved: #116365 Approved by: https://github.com/jansel
|
@pytorchbot revert -m "breaking internal builds" -c ghfirst |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@yanboliang your PR has been successfully reverted. |
This reverts commit 015bd0e. Reverted #116312 on behalf of https://github.com/kit1980 due to breaking internal builds ([comment](#116312 (comment)))
|
@pytorchbot merge |
|
Can't merge closed PR #116312 |
@malfet Why do you try to re-merge without changes? |
@kit1980 typed in a wrong window, but decided not to cancel the merge as PR is already closed, so it should have been a no-op. (as you can see from the comment) |
|
Looking at the unit test failures on the abandoned diff D52402227 |
|
@huydhn Yea, I have incorporated the fix into this PR, but it’s better executorch side can add this unit test to OSS. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: After this refactor: * ```TorchVariable``` definition and all references are removed. * All ```is_allowed``` references except one are removed. - The only left one is in ```torch/_dynamo/decorators:_disallow_in_graph_helper```. It was called when users put ```disallow_in_graph``` decorator on a function. Since we use the lists in ```trace_rules``` to decide the function's trace rule, so the decorator would only be used as customer function rather than torch functions. I'll defer this to a separate decorator refactor PR. X-link: pytorch/pytorch#116312 Approved by: https://github.com/jansel Reviewed By: izaitsevfb Differential Revision: D52491036 Pulled By: yanboliang fbshipit-source-id: 2c6e4775fdee15870d07e2095bc87f655c13a685
After this refactor: * ```TorchVariable``` definition and all references are removed. * All ```is_allowed``` references except one are removed. - The only left one is in ```torch/_dynamo/decorators:_disallow_in_graph_helper```. It was called when users put ```disallow_in_graph``` decorator on a function. Since we use the lists in ```trace_rules``` to decide the function's trace rule, so the decorator would only be used as customer function rather than torch functions. I'll defer this to a separate decorator refactor PR. Pull Request resolved: pytorch#116312 Approved by: https://github.com/jansel
After this refactor:
TorchVariabledefinition and all references are removed.is_allowedreferences except one are removed.torch/_dynamo/decorators:_disallow_in_graph_helper. It was called when users putdisallow_in_graphdecorator on a function. Since we use the lists intrace_rulesto decide the function's trace rule, so the decorator would only be used as customer function rather than torch functions. I'll defer this to a separate decorator refactor PR.cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng