Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use jemalloc for CUDA builds #116900

Closed
wants to merge 2 commits into from
Closed

[CI] Use jemalloc for CUDA builds #116900

wants to merge 2 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Jan 5, 2024

According to @ptrblck it'll likely mitigate non-deterministic NVCC bug
See #116289 for more detail

Test plan: ssh into one of the cuda builds and make sure that LD_PRELOAD is set for the top-level make command

According to @ptrblck it'll likely mitigate non-deterministic NVCC bug
See #116289
@malfet malfet requested a review from atalman January 5, 2024 21:10
@malfet malfet requested a review from jeffdaily as a code owner January 5, 2024 21:10
@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Jan 5, 2024
Copy link

pytorch-bot bot commented Jan 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116900

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9318e91 with merge base 0f0020d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet requested a review from a team as a code owner January 6, 2024 03:41
@malfet malfet added the topic: bug fixes topic category label Jan 6, 2024
@malfet
Copy link
Contributor Author

malfet commented Jan 6, 2024

@pytorchbot merge -f "pull is green, should not affect trunk"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

huydhn pushed a commit that referenced this pull request Jan 8, 2024
According to @ptrblck it'll likely mitigate non-deterministic NVCC bug
See #116289 for more detail

Test plan: ssh into one of the cuda builds and make sure that `LD_PRELOAD` is set for the top-level make command

Pull Request resolved: #116900
Approved by: https://github.com/atalman
malfet added a commit that referenced this pull request Jan 9, 2024
According to @ptrblck it'll likely mitigate non-deterministic NVCC bug
See #116289 for more detail

Test plan: ssh into one of the cuda builds and make sure that `LD_PRELOAD` is set for the top-level make command

Pull Request resolved: #116900
Approved by: https://github.com/atalman

Co-authored-by: Nikita Shulga <nshulga@meta.com>
@github-actions github-actions bot deleted the malfet/be-use-jemalloc branch February 20, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged release notes: releng release notes category topic: bug fixes topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants