Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[export] Remove CallSpec #117671

Closed
wants to merge 1 commit into from
Closed

[export] Remove CallSpec #117671

wants to merge 1 commit into from

Conversation

angelayi
Copy link
Contributor

Summary: This is not really being used anywhere

Test Plan: CI

Differential Revision: D52842563

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 17, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117671

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9a7d73d with merge base 6fe5a3a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52842563

angelayi added a commit to angelayi/executorch-1 that referenced this pull request Jan 17, 2024
@angelayi @facebook-github-bot
Remove CallSpec (pytorch#1618)
24823ef 
Summary:
X-link: pytorch/pytorch#117671


This is not really being used anywhere

Differential Revision: D52842563
angelayi added a commit to angelayi/pytorch that referenced this pull request Jan 17, 2024
@angelayi @facebook-github-bot
[export] Remove CallSpec (pytorch#117671)
c4ecf23 
Summary:

X-link: pytorch/executorch#1618

This is not really being used anywhere

Test Plan: CI

Differential Revision: D52842563
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52842563

angelayi added a commit to angelayi/executorch-1 that referenced this pull request Jan 17, 2024
@angelayi @facebook-github-bot
Remove CallSpec (pytorch#1618)
560030d 
Summary:
X-link: pytorch/pytorch#117671


This is not really being used anywhere

Differential Revision: D52842563
angelayi added a commit to angelayi/pytorch that referenced this pull request Jan 17, 2024
@angelayi @facebook-github-bot
[export] Remove CallSpec (pytorch#117671)
ab6c74a 
Summary:

X-link: pytorch/executorch#1618

This is not really being used anywhere

Test Plan: CI

Differential Revision: D52842563
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52842563

avikchaudhuri
avikchaudhuri approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@avikchaudhuri avikchaudhuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 17, 2024
angelayi added a commit to angelayi/executorch-1 that referenced this pull request Jan 17, 2024
@angelayi @facebook-github-bot
Remove CallSpec (pytorch#1618)
7425213 
Summary:
X-link: pytorch/pytorch#117671


This is not really being used anywhere

Differential Revision: D52842563
angelayi added a commit to angelayi/pytorch that referenced this pull request Jan 17, 2024
@angelayi @facebook-github-bot
[export] Remove CallSpec (pytorch#117671)
c54cd71 
Summary:

X-link: pytorch/executorch#1618

This is not really being used anywhere

Test Plan: CI

Differential Revision: D52842563
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52842563

angelayi added a commit to angelayi/executorch-1 that referenced this pull request Jan 22, 2024
@angelayi @facebook-github-bot
Remove CallSpec (pytorch#1618)
86a8712 
Summary:
X-link: pytorch/pytorch#117671


This is not really being used anywhere

Reviewed By: zhxchen17

Differential Revision: D52842563
angelayi added a commit to angelayi/pytorch that referenced this pull request Jan 22, 2024
@angelayi @facebook-github-bot
[export] Remove CallSpec (pytorch#117671)
78cbac1 
Summary:

X-link: pytorch/executorch#1618

This is not really being used anywhere

Test Plan: CI

Reviewed By: zhxchen17

Differential Revision: D52842563
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52842563

angelayi added a commit to angelayi/pytorch that referenced this pull request Jan 27, 2024
@angelayi @facebook-github-bot
[export] Remove CallSpec (pytorch#117671)
8ee459a 
Summary:

X-link: pytorch/executorch#1618

This is not really being used anywhere

Test Plan: CI

Reviewed By: zhxchen17

Differential Revision: D52842563
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52842563

angelayi added a commit to angelayi/executorch-1 that referenced this pull request Jan 27, 2024
@angelayi @facebook-github-bot
Remove CallSpec (pytorch#1618)
8e6801f 
Summary:
X-link: pytorch/pytorch#117671


This is not really being used anywhere

Reviewed By: zhxchen17

Differential Revision: D52842563
angelayi added a commit to angelayi/executorch-1 that referenced this pull request Jan 27, 2024
@angelayi @facebook-github-bot
Remove CallSpec (pytorch#1618)
4aae6e7 
Summary:
X-link: pytorch/pytorch#117671


This is not really being used anywhere

Reviewed By: zhxchen17

Differential Revision: D52842563
angelayi added a commit to angelayi/pytorch that referenced this pull request Jan 27, 2024
@angelayi @facebook-github-bot
[export] Remove CallSpec (pytorch#117671)
98ae506 
Summary:

X-link: pytorch/executorch#1618

This is not really being used anywhere

Test Plan: CI

Reviewed By: zhxchen17

Differential Revision: D52842563
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52842563

@zhxchen17
Copy link
Contributor

@angelayi still going?

@angelayi @facebook-github-bot
[export] Remove CallSpec (pytorch#117671)
9a7d73d 
Summary:

X-link: pytorch/executorch#1618

This is not really being used anywhere

Test Plan: CI

Reviewed By: zhxchen17

Differential Revision: D52842563
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52842563

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request Feb 8, 2024
@angelayi @jeffdaily
[export] Remove CallSpec (#117671)
811feed 
Summary: This is not really being used anywhere

Test Plan: CI

Differential Revision: D52842563

Pull Request resolved: #117671
Approved by: https://github.com/avikchaudhuri, https://github.com/zhxchen17
clee2000 pushed a commit that referenced this pull request Feb 14, 2024
@angelayi @clee2000
[export] Remove CallSpec (#117671)
f6199e0 
Summary: This is not really being used anywhere

Test Plan: CI

Differential Revision: D52842563

Pull Request resolved: #117671
Approved by: https://github.com/avikchaudhuri, https://github.com/zhxchen17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhxchen17 zhxchen17 zhxchen17 approved these changes

@avikchaudhuri avikchaudhuri avikchaudhuri approved these changes

@gmagogsfm gmagogsfm Awaiting requested review from gmagogsfm gmagogsfm is a code owner

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@angelayi @facebook-github-bot @zhxchen17 @pytorchmergebot @avikchaudhuri