[Inductor] Use codegen reference for buffer to string #117838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117838
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 53978ea with merge base 4057d00 ( UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D52899373 |
Summary: The added test case ends up emitting an inductor IR as the buffer string, lets properly emit the buffer name instead. Test Plan: added new test Reviewed By: zoranzhao, tissue3 Differential Revision: D52899373
oulgen
force-pushed
the
export-D52899373
branch
from
884613b
to
53978ea
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52899373 |
aakhundov
approved these changes
Jan 19, 2024
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
aakhundov
added a commit
to aakhundov/pytorch
that referenced
this pull request
Jan 20, 2024
Summary: Recently, this has been fixed for the Python wrapper codegen in D52899373 (pytorch#117838). Here we extend the fix to CPP wrapper codegen / AOTInductor. Test Plan: New unit tests. In OSS: ``` python test/inductor/test_aot_inductor.py -k test_triton_kernel_multi_output_arg ``` ``` python test/inductor/test_aot_inductor.py -k test_triton_kernel_extern_kernel_arg ``` Differential Revision: D52936248
aakhundov
added a commit
to aakhundov/pytorch
that referenced
this pull request
Jan 20, 2024
) Summary: Recently, this has been fixed for the Python wrapper codegen in D52899373 (pytorch#117838). Here we extend the fix to CPP wrapper codegen / AOTInductor. Test Plan: New unit tests. In OSS: ``` python test/inductor/test_aot_inductor.py -k test_triton_kernel_multi_output_arg ``` ``` python test/inductor/test_aot_inductor.py -k test_triton_kernel_extern_kernel_arg ``` Differential Revision: D52936248
aakhundov
added a commit
to aakhundov/pytorch
that referenced
this pull request
Jan 20, 2024
) Summary: Recently, this has been fixed for the Python wrapper codegen in D52899373 (pytorch#117838). Here we extend the fix to CPP wrapper codegen / AOTInductor. Test Plan: New unit tests. In OSS: ``` python test/inductor/test_aot_inductor.py -k test_triton_kernel_multi_output_arg ``` ``` python test/inductor/test_aot_inductor.py -k test_triton_kernel_extern_kernel_arg ``` Differential Revision: D52936248
aakhundov
added a commit
to aakhundov/pytorch
that referenced
this pull request
Jan 20, 2024
) Summary: Recently, this has been fixed for the Python wrapper codegen in D52899373 (pytorch#117838). Here we extend the fix to CPP wrapper codegen / AOTInductor. Test Plan: New unit tests. In OSS: ``` python test/inductor/test_aot_inductor.py -k test_triton_kernel_multi_output_arg ``` ``` python test/inductor/test_aot_inductor.py -k test_triton_kernel_extern_kernel_arg ``` Reviewed By: oulgen Differential Revision: D52936248
aakhundov
added a commit
to aakhundov/pytorch
that referenced
this pull request
Jan 20, 2024
) Summary: Recently, this has been fixed for the Python wrapper codegen in D52899373 (pytorch#117838). Here we extend the fix to CPP wrapper codegen / AOTInductor. Test Plan: New unit tests. In OSS: ``` python test/inductor/test_aot_inductor.py -k test_triton_kernel_multi_output_arg ``` ``` python test/inductor/test_aot_inductor.py -k test_triton_kernel_extern_kernel_arg ``` Reviewed By: oulgen, chenyang78 Differential Revision: D52936248
aakhundov
added a commit
to aakhundov/pytorch
that referenced
this pull request
Jan 20, 2024
) Summary: Recently, this has been fixed for the Python wrapper codegen in D52899373 (pytorch#117838). Here we extend the fix to CPP wrapper codegen / AOTInductor. Test Plan: New unit tests. In OSS: ``` python test/inductor/test_aot_inductor.py -k test_triton_kernel_multi_output_arg ``` ``` python test/inductor/test_aot_inductor.py -k test_triton_kernel_extern_kernel_arg ``` Reviewed By: oulgen, chenyang78 Differential Revision: D52936248
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 21, 2024
Summary: We see IR nodes `repr`-ed directly in the CPP wrapper codegen. Recently, this issue has been fixed for the Python wrapper codegen in D52899373 (#117838). Here we extend the fix to CPP wrapper codegen / AOTInductor. Test Plan: New unit tests. In OSS: ``` python test/inductor/test_aot_inductor.py -k test_triton_kernel_multi_output_arg ``` ``` python test/inductor/test_aot_inductor.py -k test_triton_kernel_extern_kernel_arg ``` Differential Revision: D52936248 Pull Request resolved: #117931 Approved by: https://github.com/oulgen, https://github.com/chenyang78, https://github.com/desertfire
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The added test case ends up emitting an inductor IR as the buffer string, lets properly emit the buffer name instead.
Test Plan: added new test
Differential Revision: D52899373
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler