[C10D] Fix nccl flightrecorder ignored dump timeout #118142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't call future.get() unless it's ready, because it waits. Also, refactor the code a bit for simplicity. We should do a follow-on PR to clean up the timeouts further, but this should fix the glaring timeout bug. [ghstack-poisoned]
pytorch-bot
bot
added
the
release notes: distributed (c10d)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/118142
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 449e97f with merge base 0528602 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wconstab
added a commit
that referenced
this pull request
Jan 23, 2024
Don't call future.get() unless it's ready, because it waits. Also, refactor the code a bit for simplicity. We should do a follow-on PR to clean up the timeouts further, but this should fix the glaring timeout bug. ghstack-source-id: 70ff3ea3185f8b085917dccabadd706839bddf80 Pull Request resolved: #118142
github-actions
bot
added
the
oncall: distributed
Don't call future.get() unless it's ready, because it waits. Also, refactor the code a bit for simplicity. We should do a follow-on PR to clean up the timeouts further, but this should fix the glaring timeout bug. cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l yf225 [ghstack-poisoned]
wconstab
added a commit
that referenced
this pull request
Jan 23, 2024
Don't call future.get() unless it's ready, because it waits. Also, refactor the code a bit for simplicity. We should do a follow-on PR to clean up the timeouts further, but this should fix the glaring timeout bug. ghstack-source-id: 1b649b3586d377d18eb652d9a0e56ff7657c3338 Pull Request resolved: #118142
9 tasks
| @@ -1012,29 +1012,31 @@ void ProcessGroupNCCL::waitForDumpOrTimeout( | |||
| TORCH_CHECK(fut.valid(), "Expected a valid future"); | |||
|
|
|||
| auto futStatus = fut.wait_for(std::chrono::seconds(timeout_sec)); | |||
There was a problem hiding this comment.
I am not sure the default times are set properly, e.g., the default timeout_sec is 30s, so we wait for a max of 30s for local dump here, which should long pass the wakeUpTime point (default 2 secs after init dumping)?
There was a problem hiding this comment.
yea, we need to clean up the time variables.
shuqiangzhang
approved these changes
Jan 25, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
wconstab
added a commit
that referenced
this pull request
Jan 26, 2024
Don't call future.get() unless it's ready, because it waits. Also, refactor the code a bit for simplicity. We should do a follow-on PR to clean up the timeouts further, but this should fix the glaring timeout bug. Pull Request resolved: #118142 Approved by: https://github.com/shuqiangzhang ghstack dependencies: #118044, #118046, #118047
wconstab
added a commit
that referenced
this pull request
Jan 26, 2024
Don't call future.get() unless it's ready, because it waits. Also, refactor the code a bit for simplicity. We should do a follow-on PR to clean up the timeouts further, but this should fix the glaring timeout bug. Pull Request resolved: #118142 Approved by: https://github.com/shuqiangzhang ghstack dependencies: #118044, #118046, #118047
wconstab
added a commit
that referenced
this pull request
Jan 26, 2024
Don't call future.get() unless it's ready, because it waits. Also, refactor the code a bit for simplicity. We should do a follow-on PR to clean up the timeouts further, but this should fix the glaring timeout bug. Pull Request resolved: #118142 Approved by: https://github.com/shuqiangzhang ghstack dependencies: #118044, #118046, #118047
wconstab
added a commit
that referenced
this pull request
Jan 27, 2024
Don't call future.get() unless it's ready, because it waits. Also, refactor the code a bit for simplicity. We should do a follow-on PR to clean up the timeouts further, but this should fix the glaring timeout bug. Pull Request resolved: #118142 Approved by: https://github.com/shuqiangzhang ghstack dependencies: #118044, #118046, #118047
wconstab
added a commit
that referenced
this pull request
Jan 27, 2024
Don't call future.get() unless it's ready, because it waits. Also, refactor the code a bit for simplicity. We should do a follow-on PR to clean up the timeouts further, but this should fix the glaring timeout bug. Pull Request resolved: #118142 Approved by: https://github.com/shuqiangzhang ghstack dependencies: #118044, #118046, #118047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Don't call future.get() unless it's ready, because it waits.
Also, refactor the code a bit for simplicity.
We should do a follow-on PR to clean up the timeouts further, but this
should fix the glaring timeout bug.
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @yf225