-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated docs styles #11835
Updated docs styles #11835
Conversation
Need a rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All internal tests pass. Thanks Brian.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local build is busted. It succeeds, but when viewing, I'm getting a lot of http errors, e.g.,
127.0.0.1 - - [19/Sep/2018 07:55:59] "GET /build/html/_static/images/chevron-right-orange.svg HTTP/1.1" 304 -
127.0.0.1 - - [19/Sep/2018 07:55:59] code 404, message File not found
127.0.0.1 - - [19/Sep/2018 07:55:59] code 404, message File not found
I installed the dependencies and used the usual build command make clean; make html
.
|
||
html_theme = 'pytorch_sphinx_theme' | ||
html_theme_path = [pytorch_sphinx_theme.get_html_theme_path()] | ||
|
||
# Theme options are theme-specific and customize the look and feel of a theme |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SsnL has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
After cmd+shift+r the website loads! Thanks @brianjo . However, it seems that the declarations are all rendered wrongly, e.g.,
and
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes based on @ssnl's comments (website not rendering correctly locally)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weiyangfb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Updated requirements.txt and conf.py. Pull Request resolved: pytorch#11835 Reviewed By: SsnL Differential Revision: D9941160 Pulled By: brianjo fbshipit-source-id: fbac91214558e6d17beff74261d990c7dc762038
Updated requirements.txt and conf.py.