Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs styles #11835

Closed
wants to merge 6 commits into from
Closed

Updated docs styles #11835

wants to merge 6 commits into from

Conversation

brianjo
Copy link
Contributor

@brianjo brianjo commented Sep 18, 2018

Updated requirements.txt and conf.py.

@ssnl
Copy link
Collaborator

ssnl commented Sep 18, 2018

Need a rebase

Copy link
Contributor

@ericnakagawa ericnakagawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All internal tests pass. Thanks Brian.

Copy link
Collaborator

@ssnl ssnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local build is busted. It succeeds, but when viewing, I'm getting a lot of http errors, e.g.,

127.0.0.1 - - [19/Sep/2018 07:55:59] "GET /build/html/_static/images/chevron-right-orange.svg HTTP/1.1" 304 -
127.0.0.1 - - [19/Sep/2018 07:55:59] code 404, message File not found
127.0.0.1 - - [19/Sep/2018 07:55:59] code 404, message File not found

I installed the dependencies and used the usual build command make clean; make html.


html_theme = 'pytorch_sphinx_theme'
html_theme_path = [pytorch_sphinx_theme.get_html_theme_path()]

# Theme options are theme-specific and customize the look and feel of a theme

This comment was marked as off-topic.

@ssnl
Copy link
Collaborator

ssnl commented Sep 19, 2018

Here's how local build looks like for me.

screenshot 2018-09-19 10 57 32

screenshot 2018-09-19 10 57 40

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SsnL has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ssnl
Copy link
Collaborator

ssnl commented Sep 19, 2018

After cmd+shift+r the website loads! Thanks @brianjo . However, it seems that the declarations are all rendered wrongly, e.g.,

torch.set_printoptions(precision=None, threshold=None, edgeitems=None, linewidth=None, profile=None)

looks like
screenshot 2018-09-19 11 15 07

and

torch.distributed.send(tensor, dst, group=<object object>, tag=0)

looks like
screenshot 2018-09-19 11 15 44

Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes based on @ssnl's comments (website not rendering correctly locally)

@ssnl
Copy link
Collaborator

ssnl commented Sep 19, 2018

@zou3519 Yes, this seems like a theme-related issue. @brianjo is actively working with the vendors to resolve this. Hopefully we can get this nice looking theme merged soon. :)

@ericnakagawa
Copy link
Contributor

ericnakagawa commented Sep 20, 2018

Folks, the theme issue has been resolved.

screen shot 2018-09-20 at 4 26 49 pm

Please merge. @ssnl @zou3519

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weiyangfb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

iotamudelta pushed a commit to ROCm/pytorch that referenced this pull request Sep 21, 2018
Summary:
Updated requirements.txt and conf.py.
Pull Request resolved: pytorch#11835

Reviewed By: SsnL

Differential Revision: D9941160

Pulled By: brianjo

fbshipit-source-id: fbac91214558e6d17beff74261d990c7dc762038
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants