Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix to MixtureSameFamily's _pad_mixture_dimension #118947

Closed
wants to merge 7 commits into from
Closed

Bugfix to MixtureSameFamily's _pad_mixture_dimension #118947

wants to merge 7 commits into from

Commits on Feb 1, 2024

  1. Bugfix to _pad_mixture_dimensions 

    Bugfix to _pad_mixture_dimensions. Now counts number of dimensions instead of number of elements as intended.
    @CJMenart
    CJMenart committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    f1756d0 View commit details
    Browse the repository at this point in the history

  2. +test for _pad_dimensions bugfix 

    Regression test for bugfix to _mad_mixture_dimensions in previous commit.
    @CJMenart
    CJMenart committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    95276b3 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Fix var names in test_mixture_same_family_mean_shape

    @CJMenart
    CJMenart committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    51782e0 View commit details
    Browse the repository at this point in the history

  2. MixtureSameFamilyFixed ->MixtureSameFamily

    @CJMenart
    CJMenart committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    6cff293 View commit details
    Browse the repository at this point in the history

  3. remove non-PIP space 

    Co-authored-by: Jeffrey Wan <soulitzer@gmail.com>
    @CJMenart @soulitzer
    CJMenart and soulitzer committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    e8c2f06 View commit details
    Browse the repository at this point in the history

  4. spaces after commas 

    As caught by CI
    @CJMenart
    CJMenart committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    f01b7f4 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Skip test_mixture_same_family_mean_shape in Dynamo 

    Not knowledgeable about dynamo really; making a call because test seems simple/reasonable and many other torch.distribution tests skip if Dynamo.
    @CJMenart
    CJMenart committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    0618d65 View commit details
    Browse the repository at this point in the history