[FSDP] Fixed device_mesh and auto wrap
#119064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
awgu
added a commit
that referenced
this pull request
Feb 2, 2024
ghstack-source-id: 73185b4d742035bd982e63d1c13416ff8a9c6324 Pull Request resolved: #119064
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119064
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f2b9157 with merge base 9afd539 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
added
oncall: distributed
awgu
added
the
ciflow/periodic
wz337
approved these changes
Feb 3, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorch-bot bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
If the user passes `device_mesh`, then we should not forward the process groups to the children during auto wrap and instead just rely on the `device_mesh` argument. This should fix #118906. Pull Request resolved: #119064 Approved by: https://github.com/wz337
mvpatel2000
pushed a commit
to mvpatel2000/pytorch
that referenced
this pull request
Feb 13, 2024
If the user passes `device_mesh`, then we should not forward the process groups to the children during auto wrap and instead just rely on the `device_mesh` argument. This should fix pytorch#118906. Pull Request resolved: pytorch#119064 Approved by: https://github.com/wz337
atalman
pushed a commit
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
device_meshand auto wrap #119064If the user passes
device_mesh, then we should not forward the process groups to the children during auto wrap and instead just rely on thedevice_meshargument. This should fix #118906.cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225