Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for set_flush_denormal support on ARM #119354

Closed
wants to merge 1 commit into from
Closed

Update documentation for set_flush_denormal support on ARM #119354

wants to merge 1 commit into from

Conversation

maajidkhann
Copy link
Contributor

@maajidkhann maajidkhann commented Feb 7, 2024 •
edited by pytorch-bot bot

Documentation update for set_flush_denormal():
-> set_flush_denormal() is now supported on ARM CPU's.
-> PR: #115184 (Already merged)

Reference page: https://pytorch.org/docs/stable/generated/torch.set_flush_denormal.html

cc @svekars @brycebortree

@pytorch-bot pytorch-bot bot added the release notes: python_frontend release notes category label Feb 7, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 7, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119354

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 982ca20 with merge base 0f478d9 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Feb 7, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: maajidkhann / name: MaajidKhan (982ca20)

@maajidkhann
Update documentation for set_flush_denormal
982ca20 
*set_flush_denormal() is now supported on ARM CPU's.
PR:pytorch#115184

Signed-off-by: maajidkhann <maajidkhan.n@fujitsu.com>
@drisspg drisspg added the topic: docs topic category label Feb 8, 2024
@pytorch pytorch deleted a comment from pytorch-bot bot Feb 8, 2024
@drisspg
Copy link
Contributor

drisspg commented Feb 8, 2024

To merge this you need to sign the easycla

@cpuhrsch cpuhrsch assigned cpuhrsch and unassigned cpuhrsch Feb 8, 2024
@cpuhrsch cpuhrsch added module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Feb 8, 2024
@maajidkhann
Copy link
Contributor Author

To merge this you need to sign the easycla

@drisspg Hey Driss, easycla status is resolved now. Can you help with the merge.

@maajidkhann
Copy link
Contributor Author

@cpuhrsch Can you please help review and approve the PR for merge.

@drisspg
Copy link
Contributor

drisspg commented Feb 12, 2024

@pytorchbot merge

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 12, 2024

This PR needs to be approved by an authorized maintainer before merge.

drisspg
drisspg approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drisspg
Copy link
Contributor

drisspg commented Feb 12, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 12, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

clee2000 pushed a commit that referenced this pull request Feb 14, 2024
@maajidkhann @clee2000
Update documentation for set_flush_denormal support on ARM (#119354)
aa53599 
**Documentation update for set_flush_denormal():**
-> set_flush_denormal() is now supported on ARM CPU's.
-> **PR:** #115184  (Already merged)

**Reference page:** https://pytorch.org/docs/stable/generated/torch.set_flush_denormal.html

Pull Request resolved: #119354
Approved by: https://github.com/drisspg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drisspg drisspg drisspg approved these changes

@cpuhrsch cpuhrsch Awaiting requested review from cpuhrsch

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: docs Related to our documentation, both in docs/ and docblocks open source release notes: python_frontend release notes category topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@maajidkhann @drisspg @pytorchmergebot @cpuhrsch @pytorchbot