Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCP][state_dict] Fix the issue that get_state_dict/set_state_dict ignore the buffer #119573

Closed
wants to merge 1 commit into from

Conversation

fegin
Copy link
Contributor

@fegin fegin commented Feb 9, 2024

Stack from ghstack (oldest at bottom):

get_state_dict and set_state_dict currently do not appropriately handle the
buffers. This PR fixes thie issue.

Fixes, #119535.

Differential Revision: D53616762

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @LucasLLC

…nore the buffer

get_state_dict and set_state_dict currently do not appropriately handle the
buffers. This PR fixes thie issue.

Fixes, #119535.

Differential Revision: [D53616762](https://our.internmc.facebook.com/intern/diff/D53616762/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Feb 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119573

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit 54fe263 with merge base 454abb6 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53616762

fegin added a commit that referenced this pull request Feb 9, 2024
…nore the buffer

get_state_dict and set_state_dict currently do not appropriately handle the
buffers. This PR fixes thie issue.

Fixes, #119535.

Differential Revision: [D53616762](https://our.internmc.facebook.com/intern/diff/D53616762/)

ghstack-source-id: 214703521
Pull Request resolved: #119573
@github-actions github-actions bot added oncall: distributed Add this issue/PR to distributed oncall triage queue module: distributed_checkpoint labels Feb 9, 2024
@fegin fegin added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Feb 9, 2024
@fegin fegin requested review from wz337 and LucasLLC February 9, 2024 17:58
Copy link
Contributor

@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix.

Copy link
Contributor

@LucasLLC LucasLLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the fix!

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

fegin added a commit that referenced this pull request Feb 13, 2024
…nore the buffer (#119573)

get_state_dict and set_state_dict currently do not appropriately handle the
buffers. This PR fixes thie issue.

Fixes, #119535.

Differential Revision: [D53616762](https://our.internmc.facebook.com/intern/diff/D53616762/)

Pull Request resolved: #119573
Approved by: https://github.com/wz337, https://github.com/LucasLLC
clee2000 pushed a commit that referenced this pull request Feb 14, 2024
…nore the buffer (#119573)

get_state_dict and set_state_dict currently do not appropriately handle the
buffers. This PR fixes thie issue.

Fixes, #119535.

Differential Revision: [D53616762](https://our.internmc.facebook.com/intern/diff/D53616762/)

Pull Request resolved: #119573
Approved by: https://github.com/wz337, https://github.com/LucasLLC
@github-actions github-actions bot deleted the gh/fegin/207/head branch March 12, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: distributed_checkpoint oncall: distributed Add this issue/PR to distributed oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants