New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DCP][state_dict] Fix the issue that get_state_dict/set_state_dict ignore the buffer #119573
Conversation
…nore the buffer get_state_dict and set_state_dict currently do not appropriately handle the buffers. This PR fixes thie issue. Fixes, #119535. Differential Revision: [D53616762](https://our.internmc.facebook.com/intern/diff/D53616762/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119573
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (5 Unrelated Failures)As of commit 54fe263 with merge base 454abb6 (): FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D53616762 |
…nore the buffer get_state_dict and set_state_dict currently do not appropriately handle the buffers. This PR fixes thie issue. Fixes, #119535. Differential Revision: [D53616762](https://our.internmc.facebook.com/intern/diff/D53616762/) ghstack-source-id: 214703521 Pull Request resolved: #119573
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks for the fix!
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…nore the buffer (#119573) get_state_dict and set_state_dict currently do not appropriately handle the buffers. This PR fixes thie issue. Fixes, #119535. Differential Revision: [D53616762](https://our.internmc.facebook.com/intern/diff/D53616762/) Pull Request resolved: #119573 Approved by: https://github.com/wz337, https://github.com/LucasLLC
…nore the buffer (#119573) get_state_dict and set_state_dict currently do not appropriately handle the buffers. This PR fixes thie issue. Fixes, #119535. Differential Revision: [D53616762](https://our.internmc.facebook.com/intern/diff/D53616762/) Pull Request resolved: #119573 Approved by: https://github.com/wz337, https://github.com/LucasLLC
Stack from ghstack (oldest at bottom):
get_state_dict and set_state_dict currently do not appropriately handle the
buffers. This PR fixes thie issue.
Fixes, #119535.
Differential Revision: D53616762
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @LucasLLC