Add support for labels to ttir analysis #119836
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119836
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ed6bd38 with merge base 28f299a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
| if pid > 1: | ||
| return |
There was a problem hiding this comment.
Should we add another test where we do different things in if and else blocks with a data-dependent condition like this?
There was a problem hiding this comment.
I already have a test for that which turns into a scf.if not labels
There was a problem hiding this comment.
Interesting, so labels are only used on if ...: return? or also if can have a body and this is still generated as label?
There was a problem hiding this comment.
Depends on what happens in the body, is it dynamic or not
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
Pull Request resolved: #119838 Approved by: https://github.com/aakhundov ghstack dependencies: #119834, #119835, #119836
Stack from ghstack (oldest at bottom):
TorchRuntimeErrorwithUnsupported#119599cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng