Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lower precision check for MKLDNN on Windows #121618

Closed
wants to merge 1 commit into from
Closed

Fix lower precision check for MKLDNN on Windows #121618

wants to merge 1 commit into from

Conversation

CaoE
Copy link
Collaborator

@CaoE CaoE commented Mar 11, 2024 •
edited by pytorch-bot bot

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 11, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121618

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit c4552c4 with merge base 7a4e451 (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Mar 11, 2024
@CaoE CaoE added module: windows Windows support for PyTorch module: performance Issues related to performance, either of kernel code or framework glue ciflow/trunk Trigger trunk jobs on your pull request labels Mar 11, 2024
@CaoE CaoE changed the title Fix lower precision check for MKLDNN on windows Fix lower precision check for MKLDNN on Windows Mar 11, 2024
@Xia-Weiwen Xia-Weiwen mentioned this pull request Mar 11, 2024
Closed
@xuhancn xuhancn added intel priority matters to intel architecture from performance wise intel This tag is for PR from Intel labels Mar 11, 2024
@CaoE CaoE marked this pull request as ready for review March 11, 2024 06:18
@xuhancn xuhancn requested a review from malfet March 11, 2024 06:26
@seemethere
Copy link
Member

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@seemethere seemethere added the topic: not user facing topic category label Mar 11, 2024
@seemethere
Copy link
Member

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pianpwk pushed a commit that referenced this pull request Mar 11, 2024
@CaoE @pianpwk
Fix lower precision check for MKLDNN on Windows (#121618)
d394700 
Fixes #120788

Pull Request resolved: #121618
Approved by: https://github.com/xuhancn, https://github.com/jgong5, https://github.com/mingfeima, https://github.com/seemethere
@atalman
Copy link
Contributor

atalman commented Mar 25, 2024

@pytorchbot cherry-pick --onto release/2.2 -c regression --fixes #120788

pytorchbot pushed a commit that referenced this pull request Mar 25, 2024
@CaoE @pytorchbot
Fix lower precision check for MKLDNN on Windows (#121618)
2075470 
Fixes #120788

Pull Request resolved: #121618
Approved by: https://github.com/xuhancn, https://github.com/jgong5, https://github.com/mingfeima, https://github.com/seemethere

(cherry picked from commit 0371743)
@pytorchbot
Copy link
Collaborator

Cherry picking #121618

The cherry pick PR is at #122645 and it is linked with issue #120788

Details for Dev Infra team Raised by workflow job

atalman pushed a commit that referenced this pull request Mar 25, 2024
@pytorchbot @CaoE
Fix lower precision check for MKLDNN on Windows (#122645)
39901f2 
Fixes #120788

Pull Request resolved: #121618
Approved by: https://github.com/xuhancn, https://github.com/jgong5, https://github.com/mingfeima, https://github.com/seemethere

(cherry picked from commit 0371743)

Co-authored-by: CaoE <e.cao@intel.com>
@atalman atalman mentioned this pull request Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemethere seemethere seemethere approved these changes

@jgong5 jgong5 jgong5 approved these changes

@xuhancn xuhancn xuhancn approved these changes

@mingfeima mingfeima mingfeima approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request intel priority matters to intel architecture from performance wise intel This tag is for PR from Intel Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: performance Issues related to performance, either of kernel code or framework glue module: windows Windows support for PyTorch open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Operator performance plummets on PyTorch 2.2.1 Windows platform
8 participants
@CaoE @seemethere @pytorchmergebot @atalman @pytorchbot @jgong5 @xuhancn @mingfeima