-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make check_is_size clamp to sys.maxsize - 1, so sys.maxsize comparison returns False #122372
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122372
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b814fe3 with merge base 0b68a28 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should improve our value range comparisons within subset
and the like by always clamping, as if you do 2 * x
for this value range we'll still have the same issue.
This is strictly better than the previous state, so lgtm
…e comparison returns False" Partially fixes #113002 Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…n returns False (#122372) Partially fixes #113002 Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #122372 Approved by: https://github.com/lezcano ghstack dependencies: #122370
Stack from ghstack (oldest at bottom):
Partially fixes #113002
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang