Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make check_is_size clamp to sys.maxsize - 1, so sys.maxsize comparison returns False #122372

Closed
wants to merge 3 commits into from

Conversation

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Mar 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122372

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b814fe3 with merge base 0b68a28 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Mar 21, 2024
…n returns False

Partially fixes #113002

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 3736e3d05687705d4393f19b451db74a7d85c1ef
Pull Request resolved: #122372
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should improve our value range comparisons within subset and the like by always clamping, as if you do 2 * x for this value range we'll still have the same issue.

This is strictly better than the previous state, so lgtm

…e comparison returns False"

Partially fixes #113002

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Mar 21, 2024
…n returns False

Partially fixes #113002

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 04e63590adec2b2d9c93d008fe856d05ad214e14
Pull Request resolved: #122372
[ghstack-poisoned]
ezyang added a commit that referenced this pull request Mar 21, 2024
…n returns False

Partially fixes #113002

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: e1c530285923f75d290ae4d23d0733ca4bb4c113
Pull Request resolved: #122372
@ezyang
Copy link
Contributor Author

ezyang commented Mar 21, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 21, 2024
@ezyang ezyang added topic: not user facing topic category and removed ciflow/trunk Trigger trunk jobs on your pull request labels Mar 21, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/ezyang/2629/head branch April 21, 2024 01:53
pytorch-bot bot pushed a commit that referenced this pull request Apr 22, 2024
…n returns False (#122372)

Partially fixes #113002

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: #122372
Approved by: https://github.com/lezcano
ghstack dependencies: #122370
@ezyang ezyang mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants