Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metas for randint/rand factory functions out overload #122375

Closed
wants to merge 2 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Mar 21, 2024

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Mar 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122375

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 5feba2f with merge base failed to retrieve merge base, please contact dev infra:

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Mar 21, 2024
Fixes #121897

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 8594a8b8d2b21b308f7a7560459c1dc6ad7b478e
Pull Request resolved: #122375
@ezyang
Copy link
Contributor Author

ezyang commented Mar 21, 2024

cc @jansel on the failures here, how puzzling

@jansel
Copy link
Contributor

jansel commented Mar 21, 2024

cc @jansel on the failures here, how puzzling

edit: I have an almost-fix here #122405 (comment)

@ezyang
Copy link
Contributor Author

ezyang commented Mar 24, 2024

@pytorchbot rebase

@ezyang ezyang added ciflow/trunk Trigger trunk jobs on your pull request release notes: composability release notes category topic: bug fixes topic category labels Mar 24, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/ezyang/2630/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/122375)

pytorchmergebot pushed a commit that referenced this pull request Mar 24, 2024
Fixes #121897

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 23a4702ed3929acfb7ed8e51613408f584952cb9
Pull Request resolved: #122375
@ezyang
Copy link
Contributor Author

ezyang commented Mar 25, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: pull / before-test / llm-retrieval, trunk / before-test / llm-retrieval

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request Apr 22, 2024
Fixes #121897

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: #122375
Approved by: https://github.com/lezcano
@github-actions github-actions bot deleted the gh/ezyang/2630/head branch April 25, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo release notes: composability release notes category topic: bug fixes topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants