-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UFMT formatting on test/export #123520
UFMT formatting on test/export #123520
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123520
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 3e2d5f5 with merge base 82e0153 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
needs rebase now lintcheck.sh reveals this diff which is OK
|
Done. |
@FFFrog actually it's fine, I need to run lintcheck.sh anyway so it's not a big deal |
diff is fine although this got swizzled and will probably fail lol
|
@pytorchbot merge |
Merge failedReason: Approvers from one of the following sets are needed:
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: docker-builds / docker-build (linux.12xlarge, pytorch-linux-focal-rocm-n-1-py3) Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge -i |
@pytorchbot revert -m "lint is still broken" -c nosignal https://hud.pytorch.org/pytorch/pytorch/commit/ec7551d1b783e284cedddeb9aeabb285e653c480 |
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit ec7551d. Reverted #123520 on behalf of https://github.com/PaliC due to lint is still broken ([comment](#123520 (comment)))
@FFFrog your PR has been successfully reverted. |
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
@pytorchbot merge |
This PR needs to be approved by an authorized maintainer before merge. |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Partially addresses pytorch#123062 Ran lintrunner on: test/export Detail: ```Shell $ lintrunner -a --take UFMT --all-files ok No lint issues. Successfully applied all patches. ``` Co-authored-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#123520 Approved by: https://github.com/shink, https://github.com/ezyang
This reverts commit ec7551d. Reverted pytorch#123520 on behalf of https://github.com/PaliC due to lint is still broken ([comment](pytorch#123520 (comment)))
Partially addresses pytorch#123062 Ran lintrunner on: test/export Detail: ```Shell $ lintrunner -a --take UFMT --all-files ok No lint issues. Successfully applied all patches. ``` Co-authored-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#123520 Approved by: https://github.com/ezyang
Partially addresses pytorch#123062 Ran lintrunner on: test/export Detail: ```Shell $ lintrunner -a --take UFMT --all-files ok No lint issues. Successfully applied all patches. ``` Co-authored-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#123520 Approved by: https://github.com/ezyang
Partially addresses #123062 Ran lintrunner on: test/export Detail: ```Shell $ lintrunner -a --take UFMT --all-files ok No lint issues. Successfully applied all patches. ``` Co-authored-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #123520 Approved by: https://github.com/shink, https://github.com/ezyang
This reverts commit ec7551d. Reverted #123520 on behalf of https://github.com/PaliC due to lint is still broken ([comment](#123520 (comment)))
Partially addresses #123062
Ran lintrunner on:
test/export
Detail: