Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFMT formatting on test/mobile #123521

Closed
wants to merge 1 commit into from
Closed

Conversation

FFFrog
Copy link
Collaborator

@FFFrog FFFrog commented Apr 7, 2024

Partially addresses #123062

Ran lintrunner on:
test/mobile

Detail:

$ lintrunner -a --take UFMT --all-files
ok No lint issues.
Successfully applied all patches.

Copy link

pytorch-bot bot commented Apr 7, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123521

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit bfbdb0c with merge base 07cecf4 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang
Copy link
Contributor

ezyang commented Apr 9, 2024

lintcheck.sh reveals this diff which is ok

diff --git a/test/mobile/test_lite_script_type.py b/test/mobile/test_lite_script_type.py
index 156ffb6adcb..a0a13529be6 100644
--- a/test/mobile/test_lite_script_type.py
+++ b/test/mobile/test_lite_script_type.py
@@ -14,9 +14,9 @@ from torch.testing._internal.common_utils import run_tests, TestCase
 
 class TestLiteScriptModule(TestCase):
     def test_typing_namedtuple(self):
-        myNamedTuple = NamedTuple(  # noqa: UP014
+        myNamedTuple = NamedTuple(
             "myNamedTuple", [("a", List[torch.Tensor])]
-        )
+        )  # noqa: UP014
 
         class MyTestModule(torch.nn.Module):
             def forward(self, a: torch.Tensor):

@ezyang
Copy link
Contributor

ezyang commented Apr 9, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 9, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@FFFrog FFFrog deleted the mrl_ufmt_mobile branch April 9, 2024 15:13
sanketpurandare pushed a commit to sanketpurandare/pytorch that referenced this pull request Apr 22, 2024
Partially addresses pytorch#123062

Ran lintrunner on:
test/mobile

Detail:
```Shell
$ lintrunner -a --take UFMT --all-files
ok No lint issues.
Successfully applied all patches.
```

Pull Request resolved: pytorch#123521
Approved by: https://github.com/shink, https://github.com/ezyang
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
Partially addresses #123062

Ran lintrunner on:
test/mobile

Detail:
```Shell
$ lintrunner -a --take UFMT --all-files
ok No lint issues.
Successfully applied all patches.
```

Pull Request resolved: #123521
Approved by: https://github.com/shink, https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants