Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Reduce CI_SERIAL_LIST list #124085

Closed
wants to merge 4 commits into from
Closed

[CI] Reduce CI_SERIAL_LIST list #124085

wants to merge 4 commits into from

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Apr 15, 2024

Add serial marker for individual tests so the test file can be removed from the ci serial list
Run serial marked tests first in serial
Run all other tests afterwards in parallel

Slowly reduce list and mark individual tests as serial instead

Hope # of serial tests is small so sharding evenness doesn't get too messed up

Hopefully can do 3 procs for sm86 and cpu?

serial no longer looks like a real word to me

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @amjames @desertfire @chauhang

Copy link

pytorch-bot bot commented Apr 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124085

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 76d37e5 with merge base 9c4fc5f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@clee2000 clee2000 changed the title [experiment] Reduce CI_SERIAL_LIST list [CI] Reduce CI_SERIAL_LIST list Apr 15, 2024
@clee2000 clee2000 marked this pull request as ready for review April 16, 2024 18:35
@clee2000 clee2000 requested a review from a team as a code owner April 16, 2024 18:35
@clee2000
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 16, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Apr 18, 2024
#124085

Add @serialTest() to some tests

slow gradcheck already runs serially

Doing this slowly so its easier to check flaky issues that might get made

Pull Request resolved: #124298
Approved by: https://github.com/kit1980
trieuat pushed a commit to trieuat/pytorch that referenced this pull request Apr 21, 2024
Add serial marker for individual tests so the test file can be removed from the ci serial list
Run serial marked tests first in serial
Run all other tests afterwards in parallel

Slowly reduce list and mark individual tests as serial instead

Hope # of serial tests is small so sharding evenness doesn't get too messed up

Hopefully can do 3 procs for sm86 and cpu?

serial no longer looks like a real word to me

Pull Request resolved: pytorch#124085
Approved by: https://github.com/seemethere, https://github.com/malfet
trieuat pushed a commit to trieuat/pytorch that referenced this pull request Apr 21, 2024
pytorch#124085

Add @serialTest() to some tests

slow gradcheck already runs serially

Doing this slowly so its easier to check flaky issues that might get made

Pull Request resolved: pytorch#124298
Approved by: https://github.com/kit1980
sanketpurandare pushed a commit to sanketpurandare/pytorch that referenced this pull request Apr 22, 2024
Add serial marker for individual tests so the test file can be removed from the ci serial list
Run serial marked tests first in serial
Run all other tests afterwards in parallel

Slowly reduce list and mark individual tests as serial instead

Hope # of serial tests is small so sharding evenness doesn't get too messed up

Hopefully can do 3 procs for sm86 and cpu?

serial no longer looks like a real word to me

Pull Request resolved: pytorch#124085
Approved by: https://github.com/seemethere, https://github.com/malfet
pytorch-bot bot pushed a commit that referenced this pull request Apr 22, 2024
#124085

Add @serialTest() to some tests

slow gradcheck already runs serially

Doing this slowly so its easier to check flaky issues that might get made

Pull Request resolved: #124298
Approved by: https://github.com/kit1980
pytorchmergebot pushed a commit that referenced this pull request May 1, 2024
…125193)

* Related #124085

As in title, move test_modules and test_schema_check off CI_SERIAL_LIST
If things fail, they can get the serialTest decorator instead
Pull Request resolved: #125193
Approved by: https://github.com/huydhn
andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024
…ytorch#125193)

* Related pytorch#124085

As in title, move test_modules and test_schema_check off CI_SERIAL_LIST
If things fail, they can get the serialTest decorator instead
Pull Request resolved: pytorch#125193
Approved by: https://github.com/huydhn
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
Add serial marker for individual tests so the test file can be removed from the ci serial list
Run serial marked tests first in serial
Run all other tests afterwards in parallel

Slowly reduce list and mark individual tests as serial instead

Hope # of serial tests is small so sharding evenness doesn't get too messed up

Hopefully can do 3 procs for sm86 and cpu?

serial no longer looks like a real word to me

Pull Request resolved: #124085
Approved by: https://github.com/seemethere, https://github.com/malfet
petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
pytorch#124085

Add @serialTest() to some tests

slow gradcheck already runs serially

Doing this slowly so its easier to check flaky issues that might get made

Pull Request resolved: pytorch#124298
Approved by: https://github.com/kit1980
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
…125193)

* Related #124085

As in title, move test_modules and test_schema_check off CI_SERIAL_LIST
If things fail, they can get the serialTest decorator instead
Pull Request resolved: #125193
Approved by: https://github.com/huydhn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-td-distributed ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor release notes: releng release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants