Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] cuda 124 arm wheel test #124112

Closed
wants to merge 23 commits into from
Closed

Conversation

tinglvv
Copy link
Collaborator

@tinglvv tinglvv commented Apr 15, 2024

Test pytorch/builder#1775 (merged) for ARM wheel addition
Test pytorch/builder#1804 (WIP) for setting MAX_JOBS

Copy link

pytorch-bot bot commented Apr 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124112

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures

As of commit 339f679 with merge base e04c7b1 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 15, 2024
@tinglvv tinglvv changed the title cuda 124 arm wheel test [draft] cuda 124 arm wheel test Apr 15, 2024
@Aidyn-A Aidyn-A added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Apr 15, 2024
Copy link

pytorch-bot bot commented Apr 15, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot pytorch-bot bot removed the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Apr 15, 2024
@Aidyn-A Aidyn-A added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Apr 15, 2024
@ptrblck
Copy link
Collaborator

ptrblck commented Apr 15, 2024

I believe the origin is set to https://github.com/pytorch/builder, which does not contain your branch, so you would need to change it or create a branch in pytorch/builder instead of your fork.

@tinglvv
Copy link
Collaborator Author

tinglvv commented Apr 22, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased cuda-124-arm-test onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout cuda-124-arm-test && git pull --rebase)

@tinglvv
Copy link
Collaborator Author

tinglvv commented Apr 25, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased cuda-124-arm-test onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout cuda-124-arm-test && git pull --rebase)

@tinglvv
Copy link
Collaborator Author

tinglvv commented May 3, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/124112/head returned non-zero exit code 1

Rebasing (1/13)
Auto-merging .github/scripts/generate_binary_build_matrix.py
CONFLICT (content): Merge conflict in .github/scripts/generate_binary_build_matrix.py
error: could not apply 44f9c4c57e9... cuda 124 arm wheel test
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 44f9c4c57e9... cuda 124 arm wheel test

Raised by https://github.com/pytorch/pytorch/actions/runs/8934362376

@@ -192,6 +198,7 @@ def translate_desired_cuda(gpu_arch_type: str, gpu_arch_version: str) -> str:
"cpu-aarch64": "cpu",
"cpu-cxx11-abi": "cpu-cxx11-abi",
"cuda": f"cu{gpu_arch_version.replace('.', '')}",
"cuda-aarch64": "12.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as line above this probably needs to be cu124

@@ -222,6 +222,69 @@ jobs:
conda-pytorchbot-token-test: ${{ secrets.CONDA_PYTORCHBOT_TOKEN_TEST }}
uses: ./.github/workflows/_binary-upload.yml

conda-py3_8-cuda12_4-build:
Copy link
Contributor

@atalman atalman May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be changing conda nightly files, windows workflows etc.. Can you rebase please ? it should solve this issue.

pytorchmergebot pushed a commit that referenced this pull request May 27, 2024
rebasing #124112.
too many conflict files, so starting a new PR.

Test pytorch/builder#1775 (merged) for ARM wheel addition
Test pytorch/builder#1828 (merged) for setting MAX_JOBS

Current issue to follow up:
#126980

Co-authored-by: Aidyn-A <aidyn.b.aitzhan@gmail.com>
Pull Request resolved: #126174
Approved by: https://github.com/nWEIdia, https://github.com/atalman
@tinglvv tinglvv closed this May 27, 2024
@tinglvv tinglvv deleted the cuda-124-arm-test branch May 27, 2024 06:21
titaiwangms pushed a commit to titaiwangms/pytorch that referenced this pull request May 28, 2024
rebasing pytorch#124112.
too many conflict files, so starting a new PR.

Test pytorch/builder#1775 (merged) for ARM wheel addition
Test pytorch/builder#1828 (merged) for setting MAX_JOBS

Current issue to follow up:
pytorch#126980

Co-authored-by: Aidyn-A <aidyn.b.aitzhan@gmail.com>
Pull Request resolved: pytorch#126174
Approved by: https://github.com/nWEIdia, https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR open source topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants