[sym_shapes][perf] Use sympy xreplace instead of subs

[IvanKobzarev]

Stack from ghstack (oldest at bottom):

• -> [sym_shapes][perf] Use sympy xreplace instead of subs #124208

sympy/sympy#22240

Differential Revision: D56207553

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124208

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 013ad44 with merge base 72271fb ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[IvanKobzarev]

@IvanKobzarev has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[ezyang]

cc @asmeurer

[ezyang]

looks like you need to make the xreplace dicts

[IvanKobzarev]

@IvanKobzarev has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[lezcano]

Would it be too mad to write a regression test that looks at the source of symbolic_shapes.py and perhaps the files under the utils/_sympy folder and makes sure we are not using sub?

[lezcano]

This is a dupe of #124207. Which one are we going with?

[facebook-github-bot]

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

[pytorchmergebot]

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here