Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NJT] Inline through torch.nested.nested_tensor_from_jagged instead of graph break #124343

Closed
wants to merge 4 commits into from

Conversation

Copy link

pytorch-bot bot commented Apr 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124343

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Unrelated Failures

As of commit 53d8ecf with merge base bad8d25 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

soulitzer added a commit that referenced this pull request Apr 17, 2024
…f graph break

ghstack-source-id: c909b3623893854affa046484897359e686e7ccd
Pull Request resolved: #124343
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

…d instead of graph break"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang

[ghstack-poisoned]
soulitzer added a commit that referenced this pull request Apr 18, 2024
…f graph break

ghstack-source-id: be335904d25b1b1544ef948dc62bd7f6abd349e0
Pull Request resolved: #124343
@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 18, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@jbschlosser
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / rocm6.0-py3.8-inductor / test (inductor, 1, 1, linux.rocm.gpu.2)

Details for Dev Infra team Raised by workflow job

@soulitzer
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: inductor / rocm6.0-py3.8-inductor / test (inductor, 1, 1, linux.rocm.gpu.2)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@DanilBaibak
Copy link
Contributor

@pytorchbot revert -m "Broken trunk" -c nosignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@soulitzer your PR has been successfully reverted.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@soulitzer
Copy link
Contributor Author

@pytorchbot merge -i

pytorch-bot bot pushed a commit that referenced this pull request Apr 21, 2024
pytorch-bot bot pushed a commit that referenced this pull request Apr 21, 2024
…nstead of graph break (#124343)"

This reverts commit ef93402.

Reverted #124343 on behalf of https://github.com/DanilBaibak due to Broken trunk ([comment](#124343 (comment)))
pytorch-bot bot pushed a commit that referenced this pull request Apr 21, 2024
pytorch-bot bot pushed a commit that referenced this pull request Apr 22, 2024
pytorch-bot bot pushed a commit that referenced this pull request Apr 22, 2024
…nstead of graph break (#124343)"

This reverts commit ef93402.

Reverted #124343 on behalf of https://github.com/DanilBaibak due to Broken trunk ([comment](#124343 (comment)))
pytorch-bot bot pushed a commit that referenced this pull request Apr 22, 2024
pytorchmergebot pushed a commit that referenced this pull request Apr 23, 2024
carmocca pushed a commit to carmocca/pytorch that referenced this pull request Apr 29, 2024
andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024
andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024
…nstead of graph break (pytorch#124343)"

This reverts commit ef93402.

Reverted pytorch#124343 on behalf of https://github.com/DanilBaibak due to Broken trunk ([comment](pytorch#124343 (comment)))
andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024
andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024
petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
…nstead of graph break (pytorch#124343)"

This reverts commit ef93402.

Reverted pytorch#124343 on behalf of https://github.com/DanilBaibak due to Broken trunk ([comment](pytorch#124343 (comment)))
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
soulitzer added a commit that referenced this pull request May 8, 2024
atalman pushed a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants