Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix appending kernel to an unrelated runtime event #124389

Closed
wants to merge 1 commit into from
Closed

fix appending kernel to an unrelated runtime event #124389

wants to merge 1 commit into from

Conversation

fwenguang
Copy link
Contributor

Fixes #124388

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 18, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124389

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 5581c50 with merge base d59f1da (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@aaronenyeshi aaronenyeshi added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module release notes: profiler release notes category topic: bug fixes topic category labels Apr 18, 2024
@fwenguang fwenguang mentioned this pull request Apr 23, 2024
Closed
@aaronenyeshi
Copy link
Member

Looks good, but since we are merging a similar PR #124596, let's close this?

@fwenguang fwenguang closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronenyeshi aaronenyeshi Awaiting requested review from aaronenyeshi aaronenyeshi is a code owner

Assignees
No one assigned
Labels
open source release notes: profiler release notes category topic: bug fixes topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Profiler] Maybe append a kernel to an unrelated event.
3 participants
@fwenguang @aaronenyeshi @pytorchbot