-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some update #124450
base: gh/tugsbayasgalan/208/base
Are you sure you want to change the base?
Some update #124450
Conversation
[ghstack-poisoned]
ghstack-source-id: a8555ff022645774f034133c274e2774e06a2850 Pull Request resolved: #124450
[ghstack-poisoned]
ghstack-source-id: 15bbc3f4ce78a53df130406d24c9c6fd105da2af Pull Request resolved: #124450
@@ -1 +1 @@ | |||
d4b3e5cc607e97afdba79dc90f8ef968142f347c | |||
554cd2792cf684818b9f33106eb1a6d19bb1f85bq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed
|
||
return torch.export.export(traced_mod, export_example_inputs, example_kwarg_inputs, strict=False).module() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about some correctness verification logic between traced vs exported program?
@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
3 similar comments
@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ghstack-source-id: 15bbc3f4ce78a53df130406d24c9c6fd105da2af Pull Request resolved: #124450
ghstack-source-id: 15bbc3f4ce78a53df130406d24c9c6fd105da2af Pull Request resolved: #124450
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang Differential Revision: [D56440611](https://our.internmc.facebook.com/intern/diff/D56440611) [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang Differential Revision: [D56440611](https://our.internmc.facebook.com/intern/diff/D56440611) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D56440611 |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang Differential Revision: [D56440611](https://our.internmc.facebook.com/intern/diff/D56440611) [ghstack-poisoned]
…gnature Pull Request resolved: #124449 @imported-using-ghimport Differential Revision: [D56440613](https://our.internmc.facebook.com/intern/diff/D56440613/) ghstack-source-id: 9f7db3b3ff3085ab02f2cd3cd863965c7327c48a Some update Pull Request resolved: #124450 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440611](https://our.internmc.facebook.com/intern/diff/D56440611/) ghstack-source-id: 9f7db3b3ff3085ab02f2cd3cd863965c7327c48a Make CI less noisy Pull Request resolved: #124664 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440612](https://our.internmc.facebook.com/intern/diff/D56440612/) ghstack-source-id: 9f7db3b3ff3085ab02f2cd3cd863965c7327c48a
…gnature Pull Request resolved: #124449 @imported-using-ghimport Differential Revision: [D56440613](https://our.internmc.facebook.com/intern/diff/D56440613/) ghstack-source-id: 619f21e82e8f695bc3dbc5ffe68618de978e10b3 Some update Pull Request resolved: #124450 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440611](https://our.internmc.facebook.com/intern/diff/D56440611/) ghstack-source-id: 619f21e82e8f695bc3dbc5ffe68618de978e10b3 Make CI less noisy Pull Request resolved: #124664 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440612](https://our.internmc.facebook.com/intern/diff/D56440612/) ghstack-source-id: 619f21e82e8f695bc3dbc5ffe68618de978e10b3
…gnature Pull Request resolved: #124449 @imported-using-ghimport Differential Revision: [D56440613](https://our.internmc.facebook.com/intern/diff/D56440613/) ghstack-source-id: 703d6fd1f68129641d6450e1e9f295c7f895dd81 Some update Pull Request resolved: #124450 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440611](https://our.internmc.facebook.com/intern/diff/D56440611/) ghstack-source-id: 703d6fd1f68129641d6450e1e9f295c7f895dd81 Make CI less noisy Pull Request resolved: #124664 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440612](https://our.internmc.facebook.com/intern/diff/D56440612/) ghstack-source-id: 703d6fd1f68129641d6450e1e9f295c7f895dd81
…gnature Pull Request resolved: #124449 @imported-using-ghimport Differential Revision: [D56440613](https://our.internmc.facebook.com/intern/diff/D56440613/) ghstack-source-id: d823a86cff475c1785f140140b49f548a8b921f9 Some update Pull Request resolved: #124450 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440611](https://our.internmc.facebook.com/intern/diff/D56440611/) ghstack-source-id: d823a86cff475c1785f140140b49f548a8b921f9 Make CI less noisy Pull Request resolved: #124664 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440612](https://our.internmc.facebook.com/intern/diff/D56440612/) ghstack-source-id: d823a86cff475c1785f140140b49f548a8b921f9
…gnature Pull Request resolved: #124449 @imported-using-ghimport Differential Revision: [D56440613](https://our.internmc.facebook.com/intern/diff/D56440613/) ghstack-source-id: 39182d5d313da5d4d0b6b30fa8e94d974499276b Some update Pull Request resolved: #124450 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440611](https://our.internmc.facebook.com/intern/diff/D56440611/) ghstack-source-id: 39182d5d313da5d4d0b6b30fa8e94d974499276b Make CI less noisy Pull Request resolved: #124664 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440612](https://our.internmc.facebook.com/intern/diff/D56440612/) ghstack-source-id: 39182d5d313da5d4d0b6b30fa8e94d974499276b
…gnature Pull Request resolved: #124449 @imported-using-ghimport Differential Revision: [D56440613](https://our.internmc.facebook.com/intern/diff/D56440613/) ghstack-source-id: 44bafb981fef6340a542a5abf8c27fe186a91c8b Some update Pull Request resolved: #124450 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440611](https://our.internmc.facebook.com/intern/diff/D56440611/) ghstack-source-id: 44bafb981fef6340a542a5abf8c27fe186a91c8b Make CI less noisy Pull Request resolved: #124664 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440612](https://our.internmc.facebook.com/intern/diff/D56440612/) ghstack-source-id: 44bafb981fef6340a542a5abf8c27fe186a91c8b
…gnature Pull Request resolved: #124449 @imported-using-ghimport Differential Revision: [D56440613](https://our.internmc.facebook.com/intern/diff/D56440613/) ghstack-source-id: 550e93f774b6f6aa665eee31ff42c15c80907cfb Some update Pull Request resolved: #124450 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440611](https://our.internmc.facebook.com/intern/diff/D56440611/) ghstack-source-id: 550e93f774b6f6aa665eee31ff42c15c80907cfb Make CI less noisy Pull Request resolved: #124664 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440612](https://our.internmc.facebook.com/intern/diff/D56440612/) ghstack-source-id: 550e93f774b6f6aa665eee31ff42c15c80907cfb
…gnature Pull Request resolved: #124449 @imported-using-ghimport Differential Revision: [D56440613](https://our.internmc.facebook.com/intern/diff/D56440613/) ghstack-source-id: c5a0b72a295f371bdb1e0e55601e867c5ec41962 Some update Pull Request resolved: #124450 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440611](https://our.internmc.facebook.com/intern/diff/D56440611/) ghstack-source-id: c5a0b72a295f371bdb1e0e55601e867c5ec41962 Make CI less noisy Pull Request resolved: #124664 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440612](https://our.internmc.facebook.com/intern/diff/D56440612/) ghstack-source-id: c5a0b72a295f371bdb1e0e55601e867c5ec41962
…gnature Pull Request resolved: #124449 @imported-using-ghimport Differential Revision: [D56440613](https://our.internmc.facebook.com/intern/diff/D56440613/) ghstack-source-id: c056aa3cce08a23bf3271fd5a27f8c94baf109fa Some update Pull Request resolved: #124450 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440611](https://our.internmc.facebook.com/intern/diff/D56440611/) ghstack-source-id: c056aa3cce08a23bf3271fd5a27f8c94baf109fa Make CI less noisy Pull Request resolved: #124664 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @imported-using-ghimport Differential Revision: [D56440612](https://our.internmc.facebook.com/intern/diff/D56440612/) ghstack-source-id: c056aa3cce08a23bf3271fd5a27f8c94baf109fa
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang
Differential Revision: D56440611