Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inductor] share cse cache during vectorized indirect load #124597

Closed
wants to merge 8 commits into from

Commits on Apr 22, 2024

  1. also clone cse cache

    [ghstack-poisoned]
    zhuhaozhe committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    2b7b934 View commit details
    Browse the repository at this point in the history
  2. Update on "also clone cse cache"

    Fix #123502
    
    
    
    
    
    cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang
    
    [ghstack-poisoned]
    zhuhaozhe committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    45fc725 View commit details
    Browse the repository at this point in the history
  3. Update on "[inductor] allow clone cse cache during vectorized indirec…

    …t load"
    
    Fix #123502
    
    
    
    
    
    cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang
    
    [ghstack-poisoned]
    zhuhaozhe committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5c0a686 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Update on "[inductor] allow clone cse cache during vectorized indirec…

    …t load"
    
    Fix #123502
    
    `swap_buffer` do not clone the `cse.cache` which will bring redundant computation.
    We may able to clone the `cse.cache` if there is no cse value in the `expr`
    ```
    auto tmp8 =
    [&]
    {
        __at_align__ std::array<int64_t, 16> tmpbuf;
        tmp7.store(tmpbuf.data());
        return tmpbuf;
    }
    ()
    ;
    //
    // other codes
    //
    // also store tmp7 here (redundant tmp16)
    auto tmp16 =
    [&]
    {
        __at_align__ std::array<int64_t, 16> tmpbuf;
        tmp7.store(tmpbuf.data());
        return tmpbuf;
    }
    ()
    ;
    ```
    
    
    
    
    cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang
    
    [ghstack-poisoned]
    zhuhaozhe committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    5e0a650 View commit details
    Browse the repository at this point in the history
  2. Update on "[inductor] allow clone cse cache during vectorized indirec…

    …t load"
    
    Fix #123502
    
    `swap_buffer` do not clone the `cse.cache` which will bring redundant computation.
    We may able to clone the `cse.cache` if there is no cse value in the `expr`
    ```
    auto tmp8 =
    [&]
    {
        __at_align__ std::array<int64_t, 16> tmpbuf;
        tmp7.store(tmpbuf.data());
        return tmpbuf;
    }
    ()
    ;
    //
    // other codes
    //
    // also store tmp7 here (redundant tmp16)
    auto tmp16 =
    [&]
    {
        __at_align__ std::array<int64_t, 16> tmpbuf;
        tmp7.store(tmpbuf.data());
        return tmpbuf;
    }
    ()
    ;
    ```
    
    
    
    
    cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang
    
    [ghstack-poisoned]
    zhuhaozhe committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    bfb7411 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Update on "[inductor] allow clone cse cache during vectorized indirec…

    …t load"
    
    Fix #123502
    
    `swap_buffer` do not clone the `cse.cache` which will bring redundant computation.
    We may able to clone the `cse.cache` if there is no cse value in the `expr`
    ```
    auto tmp8 =
    [&]
    {
        __at_align__ std::array<int64_t, 16> tmpbuf;
        tmp7.store(tmpbuf.data());
        return tmpbuf;
    }
    ()
    ;
    //
    // other codes
    //
    // also store tmp7 here (redundant tmp16)
    auto tmp16 =
    [&]
    {
        __at_align__ std::array<int64_t, 16> tmpbuf;
        tmp7.store(tmpbuf.data());
        return tmpbuf;
    }
    ()
    ;
    ```
    
    
    
    
    cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang
    
    [ghstack-poisoned]
    zhuhaozhe committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b56f40e View commit details
    Browse the repository at this point in the history
  2. Update on "[inductor] allow clone cse cache during vectorized indirec…

    …t load"
    
    Fix #123502
    
    `swap_buffer` do not clone the `cse.cache` which will bring redundant computation.
    We may able to clone the `cse.cache` if there is no cse value in the `expr`
    ```
    auto tmp8 =
    [&]
    {
        __at_align__ std::array<int64_t, 16> tmpbuf;
        tmp7.store(tmpbuf.data());
        return tmpbuf;
    }
    ()
    ;
    //
    // other codes
    //
    // also store tmp7 here (redundant tmp16)
    auto tmp16 =
    [&]
    {
        __at_align__ std::array<int64_t, 16> tmpbuf;
        tmp7.store(tmpbuf.data());
        return tmpbuf;
    }
    ()
    ;
    ```
    
    
    
    
    cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang
    
    [ghstack-poisoned]
    zhuhaozhe committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    76f4af7 View commit details
    Browse the repository at this point in the history
  3. Update on "[inductor] allow clone cse cache during vectorized indirec…

    …t load"
    
    Fix #123502
    
    `swap_buffer` do not clone the `cse.cache` which will bring redundant computation.
    We may able to clone the `cse.cache` if there is no cse value in the `expr`
    ```
    auto tmp8 =
    [&]
    {
        __at_align__ std::array<int64_t, 16> tmpbuf;
        tmp7.store(tmpbuf.data());
        return tmpbuf;
    }
    ()
    ;
    //
    // other codes
    //
    // also store tmp7 here (redundant tmp16)
    auto tmp16 =
    [&]
    {
        __at_align__ std::array<int64_t, 16> tmpbuf;
        tmp7.store(tmpbuf.data());
        return tmpbuf;
    }
    ()
    ;
    ```
    
    
    
    
    cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang
    
    [ghstack-poisoned]
    zhuhaozhe committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    dda79ae View commit details
    Browse the repository at this point in the history