[dynamo] Add ID_MATCH guards on inlined functions to force compilation on monkeypatching #124975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n on monkeypatching [ghstack-poisoned]
This was referenced Apr 25, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124975
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bbb3a1b with merge base ae5e2ab ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
anijain2305
added a commit
that referenced
this pull request
Apr 25, 2024
…n on monkeypatching ghstack-source-id: 84a1be86321d1f9ee3559444b2558c6cdf41465f Pull Request resolved: #124975
… compilation on monkeypatching" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 25, 2024
…n on monkeypatching ghstack-source-id: 3cdbdbc1b2f0948f1c34822999854cd301eddb32 Pull Request resolved: #124975
… compilation on monkeypatching" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 26, 2024
…n on monkeypatching ghstack-source-id: 574c3b725908ab336d284c93cf3c130b5b0a7a19 Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 27, 2024
…n on monkeypatching ghstack-source-id: 56322fa08c137e6e75fb2dcad2a47584a375d9af Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 27, 2024
…n on monkeypatching ghstack-source-id: a23546e8273e6d40de96f7883f4762eb5450c06c Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 28, 2024
…n on monkeypatching ghstack-source-id: a55dc94483574cb5aa9c44e0bcb667a49ab7683b Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 29, 2024
…n on monkeypatching ghstack-source-id: 7c9ed86f49b878554175eac804fc923967d375db Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 29, 2024
…n on monkeypatching ghstack-source-id: 828c6c37aaefe1a8cc629e61f5aa875c26c57774 Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 29, 2024
…n on monkeypatching ghstack-source-id: f0867502c3e651ddcf193344f450989ab2465927 Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 3, 2024
…n on monkeypatching ghstack-source-id: d75c9c06b03fa26e7d6855accc494dfcb9d29f54 Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 8, 2024
…n on monkeypatching ghstack-source-id: a43b71e8f2b2127d267520eb3902ff122534a580 Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 8, 2024
…n on monkeypatching ghstack-source-id: 4918600f67f5f4f4fc6306b124fe92c345d61603 Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 8, 2024
…n on monkeypatching ghstack-source-id: 4918600f67f5f4f4fc6306b124fe92c345d61603 Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 8, 2024
…n on monkeypatching ghstack-source-id: 4918600f67f5f4f4fc6306b124fe92c345d61603 Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
This was referenced May 9, 2024
anijain2305
added a commit
that referenced
this pull request
May 9, 2024
…n on monkeypatching ghstack-source-id: a110f06bb6d48aae0a8c910e2140e2a213f0b3d0 Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 9, 2024
…n on monkeypatching ghstack-source-id: 06ce803c2632cbaf23d24c8cb23409f09b2afdcc Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 10, 2024
…n on monkeypatching ghstack-source-id: 95279091749d128906ab77ebe3958cc488f43ae1 Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 14, 2024
…n on monkeypatching ghstack-source-id: eb7f1a9d19e234f396595b4447fba469e164c858 Pull Request resolved: #124975
… compilation on monkeypatching" Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/ UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 14, 2024
…n on monkeypatching ghstack-source-id: 07a44df53c81ed898330aea715bac5522e72e831 Pull Request resolved: #124975
|
Closing in favor of #126203 |
anijain2305
added a commit
that referenced
this pull request
May 15, 2024
An alternative was #124975. Though it was safer because it was adding guards for every inlined function, it was causing guard overhead for a few models of > 20%. The overhead of this PR is minimal for the common unpatched case. Fixes an internal issue - [fb.workplace.com/groups/1075192433118967/permalink/1411067766198097](https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 15, 2024
An alternative was #124975. Though it was safer because it was adding guards for every inlined function, it was causing guard overhead for a few models of > 20%. The overhead of this PR is minimal for the common unpatched case. Fixes an internal issue - [fb.workplace.com/groups/1075192433118967/permalink/1411067766198097](https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
May 15, 2024
An alternative was #124975. Though it was safer because it was adding guards for every inlined function, it was causing guard overhead for a few models of > 20%. The overhead of this PR is minimal for the common unpatched case. Fixes an internal issue - [fb.workplace.com/groups/1075192433118967/permalink/1411067766198097](https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/) Pull Request resolved: #126203 Approved by: https://github.com/ezyang
ZelboK
pushed a commit
to ZelboK/pytorch
that referenced
this pull request
May 19, 2024
…26203) An alternative was pytorch#124975. Though it was safer because it was adding guards for every inlined function, it was causing guard overhead for a few models of > 20%. The overhead of this PR is minimal for the common unpatched case. Fixes an internal issue - [fb.workplace.com/groups/1075192433118967/permalink/1411067766198097](https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/) Pull Request resolved: pytorch#126203 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes an internal issue - https://fb.workplace.com/groups/1075192433118967/permalink/1411067766198097/
UPADTE - Even though I can make CI pass, I am delaying landing this. I want to look more into guard_nn_modules flag. This PR might increase the guard overhead substantially with guard_nn_modules=True flag. So, I want to land that flag first, and then circle back to this.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang