[PT2][Optimus] Read the patterns from the config instead of hard-code passes #125136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125136
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit a7f199c with merge base a03b9a2 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mengluy0125
force-pushed
the
export-D56659934
branch
6 times, most recently
from
77ad2be
to
de42fe6
Compare
… passes
Summary: Due to the compatitbility issue, we hard coded the passes to do the pattern optimization. Here, we revisit the method since it has been a while for the changes into production packages. We instead read from the config to decide whether we do the specific pattern optimization, which makes followup pattern add easier.
Test Plan:
# local reproduce
### with all passes on
```
buck2 run mode/opt //scripts/jackiexu0313/pt2:local_model_with_pt2 -- --test_mode batch-split --model_type "cmf" --flow_id 472483751
```
```
Counter({'pattern_matcher_nodes': 2069, 'pattern_matcher_count': 1342, 'normalization_pass': 189, 'remove_split_with_size_one_pass': 82, 'scmerge_cat_removed': 34, 'scmerge_split_removed': 23, 'scmerge_cat_added': 20, 'scmerge_split_sections_removed': 14, 'split_cat_pass': 5, 'batch_aten_mul': 5, 'batch_linear': 3, 'batch_linear_post_grad': 3, 'scmerge_split_added': 2, 'batch_aten_sub': 1})
```
### with no passes on
```
buck2 run mode/opt //scripts/jackiexu0313/pt2:local_model_with_pt2 -- --test_mode None --model_type "cmf" --flow_id 47
2483751
```
```
'inductor': Counter({'pattern_matcher_nodes': 1158, 'pattern_matcher_count': 994, 'extern_calls': 345})
```
# e2e
see D56732968
Differential Revision: D56659934
mengluy0125
force-pushed
the
export-D56659934
branch
from
de42fe6
to
a7f199c
Compare
jackiexu1992
approved these changes
Apr 30, 2024
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
andoorve
pushed a commit
to andoorve/pytorch
that referenced
this pull request
May 1, 2024
… passes (pytorch#125136) Summary: Due to the compatitbility issue, we hard coded the passes to do the pattern optimization. Here, we revisit the method since it has been a while for the changes into production packages. We instead read from the config to decide whether we do the specific pattern optimization, which makes followup pattern add easier. Differential Revision: D56659934 Pull Request resolved: pytorch#125136 Approved by: https://github.com/jackiexu1992
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
May 3, 2024
… passes (pytorch#125136) Summary: Due to the compatitbility issue, we hard coded the passes to do the pattern optimization. Here, we revisit the method since it has been a while for the changes into production packages. We instead read from the config to decide whether we do the specific pattern optimization, which makes followup pattern add easier. Differential Revision: D56659934 Pull Request resolved: pytorch#125136 Approved by: https://github.com/jackiexu1992
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Due to the compatitbility issue, we hard coded the passes to do the pattern optimization. Here, we revisit the method since it has been a while for the changes into production packages. We instead read from the config to decide whether we do the specific pattern optimization, which makes followup pattern add easier.
Differential Revision: D56659934
cc @ezyang @msaroufim @bdhirsh @anijain2305 @chauhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire