[Split Build] add option to create a libtorch wheel #125249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125249
Note: Links to docs will display an error until the docs builds have been completed. ❌ 21 New FailuresAs of commit 3799254 with merge base ad7b5d3 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
reviewed
May 7, 2024
Comment on lines
+12
to
+16
| if(BUILD_LIBTORCHLESS) | ||
| target_link_libraries(${test_name} ${C10_LIB} gmock gtest gtest_main) | ||
| else() | ||
| target_link_libraries(${test_name} c10 gmock gtest gtest_main) | ||
| endif() |
There was a problem hiding this comment.
I think it's fine to just depend on ${C10_LIB}
Suggested change
| if(BUILD_LIBTORCHLESS) | |
| target_link_libraries(${test_name} ${C10_LIB} gmock gtest gtest_main) | |
| else() | |
| target_link_libraries(${test_name} c10 gmock gtest gtest_main) | |
| endif() | |
| target_link_libraries(${test_name} ${C10_LIB} gmock gtest gtest_main) |
malfet
reviewed
May 7, 2024
Comment on lines
+25
to
+37
| set(C10_CUDA_SRCS | ||
| CUDAAllocatorConfig.cpp | ||
| CUDACachingAllocator.cpp | ||
| CUDADeviceAssertionHost.cpp | ||
| CUDAException.cpp | ||
| CUDAFunctions.cpp | ||
| CUDAMallocAsyncAllocator.cpp | ||
| CUDAMiscFunctions.cpp | ||
| CUDAStream.cpp | ||
| impl/CUDAGuardImpl.cpp | ||
| impl/CUDATest.cpp | ||
| driver_api.cpp | ||
| ) |
There was a problem hiding this comment.
Perhaps a separate BE goals, but we should already have filelists for those (as we need them for bazel builds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_NUMBER