-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple most Caffe2 components from the build systems #125392
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125392
Note: Links to docs will display an error until the docs builds have been completed. ❌ 11 New Failures, 2 Unrelated FailuresAs of commit 9098062 with merge base b37bef9 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@cyyever please make all changes outside of caffe2 in a separate PR. Otherwise it's a huge pain to land internally. |
bf3b9a9
to
8203a6d
Compare
bfb6b10
to
a5dc5c2
Compare
@pytorchbot label ciflow/binaries |
@cyyever - To clarify @kit1980's point: there's a copy of caffe2 we wish to maintain internally. When you delete files here our sync process tries to delete them internally. We can choose not to sync, but if you've also modified files in the same PR then we have to do manual labor to split apart the PR. I'm trying to get the failed tests to load so I can inspect them. |
@cyyever - Thanks for this. It looks as though one of the failing tests is due to a missing |
@r-barnes I think everything works fine except the two unrelated tests. Would you merge it or me? |
@pytorchmergebot merge -i |
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
a5dc5c2
to
dbbb955
Compare
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
dbbb955
to
bb7825e
Compare
@pytorchbot rebase viable/strict |
❌ 🤖 pytorchbot command failed:
Try |
@pytorchbot --help |
PyTorchBot Help
Merge
Revert
Rebase
Label
Dr CI
cherry-pick
Closeusage: @pytorchbot close Close a PR [Can be used on issues] |
@pytorchbot rebase -s |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
bb7825e
to
9098062
Compare
…25711) Copying #125392 here so I can edit it more easily. Co-authored-by: cyy <cyyever@outlook.com> Pull Request resolved: #125711 Approved by: https://github.com/malfet
Landed with #125711 |
This PR decouples most Caffe2 components from CMake and Bazel build systems for later removal, following the recent attempts to totally remove Caffe2 which were inspired by #122527.
cc @gujinghui @PenghuiCheng @XiaobingSuper @jianyuh @jgong5 @mingfeima @sanchitintel @ashokei @jingxu10 @min-jean-cho @yanbing-j @Guobing-Chen @Xia-Weiwen @snadampal