[ROCm] enable faster_load_save for Fused_SGD

[petrex]

Reopen due to rebase error. Fixes #117599

The reported hang test : test_cuda.py::TestCuda::test_grad_scaling_autocast_fused_optimizers is passing with this PR

HSA Async copy / host wait on completion signal is resolved in MultiTensorApply.cuh

:4:command.cpp              :347 : 8881368803196 us: [pid:1268211 tid:0x7f5af80d7180] Command (InternalMarker) enqueued: 0xc4e2070
:4:rocvirtual.cpp           :556 : 8881368803201 us: [pid:1268211 tid:0x7f5af80d7180] Host wait on completion_signal=0x7f5967df3e00
:3:rocvirtual.hpp           :66  : 8881368803209 us: [pid:1268211 tid:0x7f5af80d7180] Host active wait for Signal = (0x7f5967df3e00) for -1 ns

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125456

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c4eff75 with merge base b08072f ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[petrex]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[pytorchmergebot]

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/125456/head returned non-zero exit code 1

Rebasing (1/5)
Rebasing (2/5)
Auto-merging test/test_cuda.py
CONFLICT (content): Merge conflict in test/test_cuda.py
error: could not apply cf814876534... enable test_grah_warn...() for rocm
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply cf814876534... enable test_grah_warn...() for rocm

Raised by https://github.com/pytorch/pytorch/actions/runs/8934168228

[janeyx99]

FYI as of yesterday test_grad_scaling_autocast_fused_optimizers has moved to test/test_optim.py

[janeyx99]

@crcrpar could you take a look at this PR?

[jeffdaily]

@petrex my approval is conditional on the CI fully passing. Looks like you'll need to manually rebase.

[petrex]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[pytorchmergebot]

Successfully rebased fused_sgd_rocm onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fused_sgd_rocm && git pull --rebase)

[pruthvistony]

@pytorchbot merge

[pytorchmergebot]

Merge failed

Reason: Approvers from one of the following sets are needed:

• superuser (pytorch/metamates)
• Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10)
• Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet)

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

[janeyx99]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here