Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use wrap_fx_proxy_cls for wrap_symint #125494

Closed
wants to merge 2 commits into from

Conversation

[ghstack-poisoned]
Copy link

pytorch-bot bot commented May 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125494

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit c1e817d with merge base 79af814 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request May 3, 2024
We use very little of the code in wrap_fx_proxy_cls, so dupe it out.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 5bbe9c889ac3e028453598295166ceb7589937ec
Pull Request resolved: #125494
@albanD albanD removed their request for review May 3, 2024 20:33
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this hotpath? Even if it is, I think it'd be better to keep both paths consistent, perhaps through an aux function

@ezyang
Copy link
Contributor Author

ezyang commented May 4, 2024

I'm splitting them because I had a huge headache understanding the nest of conditionals for the two cases, and I'm about to add a third case (float) which is going to be subtly different in a few ways. So I'm deabstracting, working out the concrete details, and then we can reabstract when it's done.

[ghstack-poisoned]
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting the madness that is wrap_fx_proxy_cls SGTM. We should make sure that we don't leave duped code at the end of this refactor tho.

pytorchmergebot pushed a commit that referenced this pull request May 5, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: #125496
Approved by: https://github.com/lezcano
ghstack dependencies: #125395, #125419, #125483, #125494
@github-actions github-actions bot deleted the gh/ezyang/2726/head branch June 5, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants