-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use wrap_fx_proxy_cls for wrap_symint #125494
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125494
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit c1e817d with merge base 79af814 (): FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
We use very little of the code in wrap_fx_proxy_cls, so dupe it out. Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 5bbe9c889ac3e028453598295166ceb7589937ec Pull Request resolved: #125494
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this hotpath? Even if it is, I think it'd be better to keep both paths consistent, perhaps through an aux function
I'm splitting them because I had a huge headache understanding the nest of conditionals for the two cases, and I'm about to add a third case (float) which is going to be subtly different in a few ways. So I'm deabstracting, working out the concrete details, and then we can reabstract when it's done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Splitting the madness that is wrap_fx_proxy_cls
SGTM. We should make sure that we don't leave duped code at the end of this refactor tho.
Stack from ghstack (oldest at bottom):
We use very little of the code in wrap_fx_proxy_cls, so dupe it out.
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang