-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of tabular and sizes, beef up verbosity of output graph #125507
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125507
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 28b0e92 with merge base 235b4d6 (): BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 225381cba686f4f016214923861e73f03d372d37 Pull Request resolved: #125507
@Chillee you get what you wanted, stride by default :P |
Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 9560c4967a237d37714983f3b9b5c2cd2e791010 Pull Request resolved: #125507
Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 8ab822b31e9d75c406b8d942a9753c5266c10d96 Pull Request resolved: #125507
Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 3d4b7b92e778c89e757535574ba751a3de005a52 Pull Request resolved: #125507
Did I want stride by default? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the test being deleted?
The test is testing that there is a separate log for sizes, but now that they're all in the graph we don't need this log. |
I distinctly remember you complaining to me about it :) |
Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: a96655cbe16d55b95a9e1b0a951344eb2457bcae Pull Request resolved: #125507
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang