Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of tabular and sizes, beef up verbosity of output graph #125507

Closed
wants to merge 5 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented May 3, 2024

[ghstack-poisoned]
Copy link

pytorch-bot bot commented May 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125507

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 28b0e92 with merge base 235b4d6 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request May 3, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 225381cba686f4f016214923861e73f03d372d37
Pull Request resolved: #125507
[ghstack-poisoned]
@ezyang ezyang requested review from jansel and Chillee May 5, 2024 14:14
@ezyang
Copy link
Contributor Author

ezyang commented May 5, 2024

@Chillee you get what you wanted, stride by default :P

ezyang added a commit that referenced this pull request May 5, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 9560c4967a237d37714983f3b9b5c2cd2e791010
Pull Request resolved: #125507
[ghstack-poisoned]
ezyang added a commit that referenced this pull request May 5, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 8ab822b31e9d75c406b8d942a9753c5266c10d96
Pull Request resolved: #125507
[ghstack-poisoned]
ezyang added a commit that referenced this pull request May 5, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 3d4b7b92e778c89e757535574ba751a3de005a52
Pull Request resolved: #125507
@Chillee
Copy link
Contributor

Chillee commented May 6, 2024

Did I want stride by default? 🤔

Copy link
Contributor

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the test being deleted?

@ezyang
Copy link
Contributor Author

ezyang commented May 6, 2024

Why is the test being deleted?

The test is testing that there is a separate log for sizes, but now that they're all in the graph we don't need this log.

@ezyang
Copy link
Contributor Author

ezyang commented May 6, 2024

Did I want stride by default? 🤔

I distinctly remember you complaining to me about it :)

[ghstack-poisoned]
ezyang added a commit that referenced this pull request May 6, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: a96655cbe16d55b95a9e1b0a951344eb2457bcae
Pull Request resolved: #125507
@ezyang
Copy link
Contributor Author

ezyang commented May 6, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 6, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ezyang ezyang added the topic: not user facing topic category label May 6, 2024
@ezyang
Copy link
Contributor Author

ezyang commented May 6, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/ezyang/2729/head branch June 6, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants