[BE] Abstract out strings to top of file #125640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Move const strings to top of file. This is in preparation of tooling to make use of shared constants (e.g. version string). Test Plan: python test/distributed/test_c10d_nccl.py NCCLTraceTest [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125640
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d8144ea with merge base e046c59 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
c-p-i-o
added a commit
that referenced
this pull request
May 6, 2024
Summary: Move const strings to top of file. This is in preparation of tooling to make use of shared constants (e.g. version string). Test Plan: python test/distributed/test_c10d_nccl.py NCCLTraceTest ghstack-source-id: 3a0072f6c591ff3611038e3f9caaba585ba9860f Pull Request resolved: #125640
Summary: Move const strings to top of file. This is in preparation of tooling to make use of shared constants (e.g. version string). Test Plan: python test/distributed/test_c10d_nccl.py NCCLTraceTest cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
c-p-i-o
added a commit
that referenced
this pull request
May 6, 2024
Summary: Move const strings to top of file. This is in preparation of tooling to make use of shared constants (e.g. version string). Test Plan: python test/distributed/test_c10d_nccl.py NCCLTraceTest ghstack-source-id: 9488d79e4466dc7880070338a882d9545d4df773 Pull Request resolved: #125640
Summary: Move const strings to top of file. This is in preparation of tooling to make use of shared constants (e.g. version string). Test Plan: python test/distributed/test_c10d_nccl.py NCCLTraceTest cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
c-p-i-o
added a commit
that referenced
this pull request
May 7, 2024
Summary: Move const strings to top of file. This is in preparation of tooling to make use of shared constants (e.g. version string). Test Plan: python test/distributed/test_c10d_nccl.py NCCLTraceTest ghstack-source-id: 93e48bde7e2f8b28cbca85c09144c4709afe6050 Pull Request resolved: #125640
Summary: Move const strings to top of file. This is in preparation of tooling to make use of shared constants (e.g. version string). Test Plan: python test/distributed/test_c10d_nccl.py NCCLTraceTest cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
Summary: Move const strings to top of file. This is in preparation of tooling to make use of shared constants (e.g. version string). Test Plan: python test/distributed/test_c10d_nccl.py NCCLTraceTest cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
wconstab
approved these changes
May 14, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: New commits were pushed while merging. Please rerun the merge command. Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ZelboK
pushed a commit
to ZelboK/pytorch
that referenced
this pull request
May 19, 2024
Summary: Move const strings to top of file. This is in preparation of tooling to make use of shared constants (e.g. version string). A non-functional change. Ideally we want these const strings to be available from both C++ and Python - but I haven't figured out how to correctly share things in PyTorch. I'll do this in a subsequent change. Test Plan: python test/distributed/test_c10d_nccl.py NCCLTraceTest Pull Request resolved: pytorch#125640 Approved by: https://github.com/wconstab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Move const strings to top of file. This is in preparation of tooling to
make use of shared constants (e.g. version string). A non-functional change.
Ideally we want these const strings to be available from both C++ and Python - but I haven't figured out how to correctly share things in PyTorch. I'll do this in a subsequent change.
Test Plan:
python test/distributed/test_c10d_nccl.py NCCLTraceTest
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k