[AOTI] Disable stack allocation for OSS #125732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Stack allocation is for certain small CPU models, but its coverage still needs improvement, so default to OFF for OSS. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125732
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 788e458 with merge base b40fb2d ( UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 8, 2024
Summary: Stack allocation is for certain small CPU models, but its coverage still needs improvement, so default to OFF for OSS. [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
May 9, 2024
Summary: Stack allocation is for certain small CPU models, but its coverage still needs improvement, so default to OFF for OSS. ghstack-source-id: 51693eb90ba97406a0e35689809196ffc8a73768 Pull Request resolved: #125732
Summary: Stack allocation is for certain small CPU models, but its coverage still needs improvement, so default to OFF for OSS. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
This was referenced May 16, 2024
Summary: Stack allocation is for certain small CPU models, but its coverage still needs improvement, so default to OFF for OSS. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
Summary: Stack allocation is for certain small CPU models, but its coverage still needs improvement, so default to OFF for OSS. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
This was referenced May 21, 2024
Summary: Stack allocation is for certain small CPU models, but its coverage still needs improvement, so default to OFF for OSS. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
chenyang78
approved these changes
May 21, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
added a commit
that referenced
this pull request
May 24, 2024
This reverts commit 599e684. Reverted #125732 on behalf of https://github.com/DanilBaibak due to Break internal build ([comment](#126720 (comment)))
|
@desertfire your PR has been successfully reverted. |
Summary: Stack allocation is for certain small CPU models, but its coverage still needs improvement, so default to OFF for OSS. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
May 24, 2024
Summary: Stack allocation is for certain small CPU models, but its coverage still needs improvement, so default to OFF for OSS. ghstack-source-id: c0c6ccbdb50ecd5c0dfea4f1573c81b433862af5 Pull Request resolved: #125732
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
titaiwangms
pushed a commit
to titaiwangms/pytorch
that referenced
this pull request
May 28, 2024
This reverts commit 599e684. Reverted pytorch#125732 on behalf of https://github.com/DanilBaibak due to Break internal build ([comment](pytorch#126720 (comment)))
titaiwangms
pushed a commit
to titaiwangms/pytorch
that referenced
this pull request
May 28, 2024
Summary: Stack allocation is for certain small CPU models, but its coverage still needs improvement, so default to OFF for OSS. Pull Request resolved: pytorch#125732 Approved by: https://github.com/chenyang78 ghstack dependencies: pytorch#126720, pytorch#126801
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: Stack allocation is for certain small CPU models, but its coverage still needs improvement, so default to OFF for OSS.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @chauhang