Add meta for _embedding_bag_dense_backward and _embedding_bag_per_sample_weights_backward #125785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125785
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fb4b515 with merge base 96a5698 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
added a commit
that referenced
this pull request
May 8, 2024
…ple_weights_backward Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 60294d5a62693058e34a241ec0ada9162d5ff37c Pull Request resolved: #125785
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
miladm and
SherlockNoMad
albanD
approved these changes
May 8, 2024
| # Can't easily test sum, because there is a fast path for sum which | ||
| # causes offset2bag to not get allocated... but the backward function | ||
| # needs it, and the offset2bag computation lives inside the | ||
| # derivatives.yaml formula directly, so there is no way to access it. |
There was a problem hiding this comment.
I'm not sure what you mean that the computation lives in the formula?
There was a problem hiding this comment.
you can have derivatives.yaml derivative do some compute, e.g., by directly calling a C++ function, before it eventually goes to an actual dispatched op
ezyang
added
ciflow/trunk
ezyang
added a commit
that referenced
this pull request
May 9, 2024
…ple_weights_backward Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: fba5572a2144d3d9e6089197d08a22d3a5cc368a Pull Request resolved: #125785
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang ezyang@meta.com