Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the device type for with_comms decorator #125798

Closed
wants to merge 6 commits into from

Commits on May 8, 2024

  1. fix the device type for with_comms decorator

    found by @yifuwang, it looks like we are wrongly using
    self.device_type="cuda" for gloo backend, which are triggering some
    flakiness. i.e. #125366
    
    [ghstack-poisoned]
    wanchaol committed May 8, 2024
    Configuration menu
    Copy the full SHA
    4067c30 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Update on "fix the device type for with_comms decorator"

    found by yifuwang, it looks like we are wrongly using
    self.device_type="cuda" for gloo backend, which are triggering some
    flakiness. i.e. #125366
    
    cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k
    
    [ghstack-poisoned]
    wanchaol committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ec8b2ee View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Update on "fix the device type for with_comms decorator"

    found by yifuwang, it looks like we are wrongly using
    self.device_type="cuda" for gloo backend, which are triggering some
    flakiness. i.e. #125366
    
    cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k
    
    [ghstack-poisoned]
    wanchaol committed May 14, 2024
    Configuration menu
    Copy the full SHA
    ba91c8b View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Update on "fix the device type for with_comms decorator"

    found by yifuwang, it looks like we are wrongly using
    self.device_type="cuda" for gloo backend, which are triggering some
    flakiness. i.e. #125366
    
    cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k
    
    [ghstack-poisoned]
    wanchaol committed May 15, 2024
    Configuration menu
    Copy the full SHA
    ce1073c View commit details
    Browse the repository at this point in the history
  2. Update on "fix the device type for with_comms decorator"

    found by yifuwang, it looks like we are wrongly using
    self.device_type="cuda" for gloo backend, which are triggering some
    flakiness. i.e. #125366
    
    cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k
    
    [ghstack-poisoned]
    wanchaol committed May 15, 2024
    Configuration menu
    Copy the full SHA
    0e46a91 View commit details
    Browse the repository at this point in the history
  3. Update on "fix the device type for with_comms decorator"

    found by yifuwang, it looks like we are wrongly using
    self.device_type="cuda" for gloo backend, which are triggering some
    flakiness. i.e. #125366
    
    cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k
    
    [ghstack-poisoned]
    wanchaol committed May 15, 2024
    Configuration menu
    Copy the full SHA
    d9621b6 View commit details
    Browse the repository at this point in the history