Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix torch elastic test SimpleElasticAgentTest.test_restart_workers br… #126002

Closed
wants to merge 1 commit into from
Closed

Fix torch elastic test SimpleElasticAgentTest.test_restart_workers br… #126002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/distributed/elastic/agent/server/test/api_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ def __init__(self, spec):
self.stop_workers_call_count = 0
self.start_workers_call_count = 0

def _stop_workers(self, worker_group: WorkerGroup) -> None:
def _stop_workers(
self, worker_group: WorkerGroup, is_restart: bool = False
) -> None:
# workers are fake, nothing to stop; just clear the rdzv info
worker_group.group_rank = None
worker_group.group_world_size = None
Expand Down