Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update triton pin #126098

Closed
wants to merge 26 commits into from
Closed

Update triton pin #126098

wants to merge 26 commits into from

Conversation

amjames
Copy link
Collaborator

@amjames amjames commented May 13, 2024 •
edited
Loading

@amjames
Update
b3458f0 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126098

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 7 Unrelated Failures

As of commit 965c7dc with merge base 0acd09a (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels May 13, 2024
amjames added a commit that referenced this pull request May 13, 2024
@amjames
Update triton pin to improve throughput w/ assert
7f9b9bd 
[Triton #3868](triton-lang/triton#3868) adds a
no-return annotation to generated calls to `__assertFail`. This prevents
unnecessary register reservation and should help address #120452.

cc peterbell10

ghstack-source-id: 24deb748bfd25dafbef2ceeaeb162fb6c5e93743
Pull Request resolved: #126098
@eellison
Copy link
Contributor

cc @bertmaher for triton pin update

@amjames
Update
0e2dcd9 
[ghstack-poisoned]
@amjames amjames mentioned this pull request May 14, 2024
Closed
amjames added a commit that referenced this pull request May 14, 2024
@amjames
Update triton pin to improve throughput w/ assert
b097d9a 
[Triton #3868](triton-lang/triton#3868) adds a
no-return annotation to generated calls to `__assertFail`. This prevents
unnecessary register reservation and should help address #120452.

cc peterbell10

ghstack-source-id: 739ef465c09f49e2e0032e2f985b72d74277410e
Pull Request resolved: #126098
@amjames
Update
2209cc7 
[ghstack-poisoned]
amjames added a commit that referenced this pull request May 14, 2024
@amjames
Update triton pin to improve throughput w/ assert
08b91a2 
[Triton #3868](triton-lang/triton#3868) adds a
no-return annotation to generated calls to `__assertFail`. This prevents
unnecessary register reservation and should help address #120452.

cc peterbell10

ghstack-source-id: a2e8f61ccd5bdd135f03d450b04cee9c81597b54
Pull Request resolved: #126098
amjames added a commit to amjames/pytorch that referenced this pull request May 15, 2024
@amjames
Update triton pin to improve throughput w/ assert
6e000f3 
[Triton pytorch#3868](triton-lang/triton#3868) adds a
no-return annotation to generated calls to `__assertFail`. This prevents
unnecessary register reservation and should help address pytorch#120452.

cc peterbell10

ghstack-source-id: a2e8f61ccd5bdd135f03d450b04cee9c81597b54
Pull Request resolved: pytorch#126098
amjames added a commit to amjames/pytorch that referenced this pull request May 16, 2024
@amjames
Update triton pin to improve throughput w/ assert
28baa88 
[Triton pytorch#3868](triton-lang/triton#3868) adds a
no-return annotation to generated calls to `__assertFail`. This prevents
unnecessary register reservation and should help address pytorch#120452.

cc peterbell10

ghstack-source-id: a2e8f61ccd5bdd135f03d450b04cee9c81597b54
Pull Request resolved: pytorch#126098
@amjames
Update
0f51199 
[ghstack-poisoned]
@amjames amjames mentioned this pull request May 16, 2024
Closed
@amjames
Update
965c7dc 
[ghstack-poisoned]
amjames added a commit that referenced this pull request Jun 21, 2024
@amjames
Update triton pin to improve throughput w/ assert
89970b9 
[Triton #3868](triton-lang/triton#3868) adds a
no-return annotation to generated calls to `__assertFail`. This prevents
unnecessary register reservation and should help address #120452.

cc peterbell10

ghstack-source-id: 8da15270f99e5121650bb7f2f1ec1e75f50c20f9
Pull Request resolved: #126098
@amjames amjames changed the title Update triton pin to improve throughput w/ assert Update triton pin Jun 21, 2024
@amjames
Copy link
Collaborator Author

amjames commented Jun 21, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda12_4-test / test, linux-binary-manywheel / manywheel-py3_8-cuda12_1-test / test, linux-binary-manywheel / manywheel-py3_8-cuda11_8-test / test

Details for Dev Infra team Raised by workflow job

@amjames
Copy link
Collaborator Author

amjames commented Jun 21, 2024

@pytorchbot merge -f "expected failures for pin update"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@vkuzo vkuzo mentioned this pull request Jun 24, 2024
Closed
@htyu htyu mentioned this pull request Jun 24, 2024
Closed
vkuzo added a commit to pytorch/ao that referenced this pull request Jun 24, 2024
@vkuzo
fix mx triton kernel after PyTorch triton pin change
bc234a8 
Summary:

Triton pin updated recently:
pytorch/pytorch#126098

In the new triton version, functions can only access global variables of
type `tl.constexpr`. Due to the current structure of the code and the
fact that these constants are also used by non-triton programs, I think
the best thing to do is to just stop using globals in the MX triton
kernel. The PR lifts all of these constants to kernel function
arguments.

Test Plan:

```
pytest test/prototype/mx_formats/test_custom_cast.py
```

Reviewers:

Subscribers:

Tasks:

Tags:
@vkuzo vkuzo mentioned this pull request Jun 24, 2024
Merged
vkuzo added a commit to pytorch/ao that referenced this pull request Jun 24, 2024
@vkuzo
fix mx triton kernel after PyTorch triton pin change
3330c07 
Summary:

Triton pin updated recently:
pytorch/pytorch#126098

In the new triton version, functions can only access global variables of
type `tl.constexpr`. Due to the current structure of the code and the
fact that these constants are also used by non-triton programs, I think
the best thing to do is to just stop using globals in the MX triton
kernel. The PR lifts all of these constants to kernel function
arguments.

Test Plan:

```
pytest test/prototype/mx_formats/test_custom_cast.py
```

Reviewers:

Subscribers:

Tasks:

Tags:
vkuzo added a commit to pytorch/ao that referenced this pull request Jun 24, 2024
@vkuzo
fix mx triton kernel after PyTorch triton pin change
24dd661 
Summary:

Triton pin updated recently:
pytorch/pytorch#126098

In the new triton version, functions can only access global variables of
type `tl.constexpr`. Due to the current structure of the code and the
fact that these constants are also used by non-triton programs, I think
the best thing to do is to just stop using globals in the MX triton
kernel. The PR lifts all of these constants to kernel function
arguments.

Test Plan:

```
pytest test/prototype/mx_formats/test_custom_cast.py
```

Reviewers:

Subscribers:

Tasks:

Tags:
msaroufim pushed a commit to pytorch/ao that referenced this pull request Jun 24, 2024
@vkuzo
fix mx triton kernel after PyTorch triton pin change (#431)
c2cf973 
Summary:

Triton pin updated recently:
pytorch/pytorch#126098

In the new triton version, functions can only access global variables of
type `tl.constexpr`. Due to the current structure of the code and the
fact that these constants are also used by non-triton programs, I think
the best thing to do is to just stop using globals in the MX triton
kernel. The PR lifts all of these constants to kernel function
arguments.

Test Plan:

```
pytest test/prototype/mx_formats/test_custom_cast.py
```

Reviewers:

Subscribers:

Tasks:

Tags:
q10 added a commit to q10/FBGEMM that referenced this pull request Jun 24, 2024
@q10
[fbgemm_gpu] Update pytorch-triton version
6c61c61 
- Update pytorch-triton version to follow PyTorch pytorch/pytorch#126098
@q10 q10 mentioned this pull request Jun 24, 2024
Closed
q10 added a commit to q10/FBGEMM that referenced this pull request Jun 24, 2024
@q10
[fbgemm_gpu] Update pytorch-triton version
606a142 
- Update pytorch-triton version to follow PyTorch pytorch/pytorch#126098

- Remove triton from git submodules as triton installation no longer requires this
facebook-github-bot pushed a commit to pytorch/FBGEMM that referenced this pull request Jun 24, 2024
@q10 @facebook-github-bot
Update pytorch-triton version (#2775)
d38bca1 
Summary:
- Update pytorch-triton version to follow PyTorch pytorch/pytorch#126098

Pull Request resolved: #2775

Reviewed By: brad-mengchi

Differential Revision: D58959021

Pulled By: q10

fbshipit-source-id: 575d42dc07020778ef9f201ea1a234fb92be27f2
@amjames amjames mentioned this pull request Jun 25, 2024
Closed
@jataylo jataylo mentioned this pull request Jun 28, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request Jul 2, 2024
@jataylo @pytorchmergebot
[ROCm] Update nightly triton-rocm pin to release branch (#129361)
95a5958 
Update pin to tip of https://github.com/triton-lang/triton/commits/release/3.0.x/ following upstream strategy here #126098

Pull Request resolved: #129361
Approved by: https://github.com/peterbell10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lezcano lezcano lezcano left review comments

@bertmaher bertmaher bertmaher approved these changes

@desertfire desertfire Awaiting requested review from desertfire desertfire is a code owner

@Chillee Chillee Awaiting requested review from Chillee Chillee is a code owner

@shunting314 shunting314 Awaiting requested review from shunting314 shunting314 is a code owner

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@jataylo jataylo Awaiting requested review from jataylo jataylo is a code owner

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd jithunnair-amd is a code owner

@pruthvistony pruthvistony Awaiting requested review from pruthvistony pruthvistony is a code owner

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet