[Export] Allow ExportedProgram to take empty decomp table #126142
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126142
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 90e6565 with merge base 04877dc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
StellarrZ
requested review from
zhxchen17,
SherlockNoMad,
angelayi and
tugsbayasgalan
|
@StellarrZ has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…6142) **As title.** Still, `ep.run_decompositions()` will use `core_aten_decompositions()` by default. Cases like `ep.run_decompositions(get_decompositions([]))` will use empty table, and go with [`aot_autograd_decompositions`](https://github.com/pytorch/pytorch/blob/04877dc430a6e93765471b28f422bf3e81d02c9e/torch/_functorch/aot_autograd.py#L456-459) only. **Motivation** We didn't have a clean way to pass in an empty decomp table. Since we've made `pre_dispatch` export as default and `ep.run_decompositions` remains with `aot_export_module(..., pre_dispatch=False)`, allowing empty table would help make blank control easier. **Testing** CI Also looked through all the references in fbcode. The only concern I have is whether we should update [this example](https://github.com/pytorch/pytorch/blob/04877dc430a6e93765471b28f422bf3e81d02c9e/torch/onnx/_internal/exporter.py#L817) or not. Pull Request resolved: pytorch#126142 Approved by: https://github.com/angelayi
As title.
Still,
ep.run_decompositions()will usecore_aten_decompositions()by default. Cases likeep.run_decompositions(get_decompositions([]))will use empty table, and go withaot_autograd_decompositionsonly.Motivation
We didn't have a clean way to pass in an empty decomp table. Since we've made
pre_dispatchexport as default andep.run_decompositionsremains withaot_export_module(..., pre_dispatch=False), allowing empty table would help make blank control easier.Testing
CI
Also looked through all the references in fbcode. The only concern I have is whether we should update this example or not.