Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traceable wrapper subclass support for deferred runtime asserts #126198

Closed
wants to merge 6 commits into from

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    3107d9d View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Update on "Traceable wrapper subclass support for deferred runtime as…

    …serts"
    
    
    The padded dense -> jagged conversion op has the signature:
    ```
    _fbgemm_dense_to_jagged_forward(Tensor dense, Tensor[] offsets, SymInt? total_L=None) -> Tensor
    ```
    
    when `total_L` is not specified, the meta registration has a data-dependent output shape (based on `offsets[0][-1]`). Returning an unbacked SymInt here should work in theory, but traceable wrapper subclass support is missing in later code to handle deferred runtime asserts. This PR fixes this.
    
    [ghstack-poisoned]
    jbschlosser committed May 15, 2024
    Configuration menu
    Copy the full SHA
    766de04 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Update on "Traceable wrapper subclass support for deferred runtime as…

    …serts"
    
    
    The padded dense -> jagged conversion op has the signature:
    ```
    _fbgemm_dense_to_jagged_forward(Tensor dense, Tensor[] offsets, SymInt? total_L=None) -> Tensor
    ```
    
    when `total_L` is not specified, the meta registration has a data-dependent output shape (based on `offsets[0][-1]`). Returning an unbacked SymInt here should work in theory, but traceable wrapper subclass support is missing in later code to handle deferred runtime asserts. This PR fixes this.
    
    [ghstack-poisoned]
    jbschlosser committed May 17, 2024
    Configuration menu
    Copy the full SHA
    7318b70 View commit details
    Browse the repository at this point in the history
  2. Update on "Traceable wrapper subclass support for deferred runtime as…

    …serts"
    
    
    The padded dense -> jagged conversion op has the signature:
    ```
    _fbgemm_dense_to_jagged_forward(Tensor dense, Tensor[] offsets, SymInt? total_L=None) -> Tensor
    ```
    
    when `total_L` is not specified, the meta registration has a data-dependent output shape (based on `offsets[0][-1]`). Returning an unbacked SymInt here should work in theory, but traceable wrapper subclass support is missing in later code to handle deferred runtime asserts. This PR fixes this.
    
    [ghstack-poisoned]
    jbschlosser committed May 17, 2024
    Configuration menu
    Copy the full SHA
    07386b6 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Update on "Traceable wrapper subclass support for deferred runtime as…

    …serts"
    
    
    The padded dense -> jagged conversion op has the signature:
    ```
    _fbgemm_dense_to_jagged_forward(Tensor dense, Tensor[] offsets, SymInt? total_L=None) -> Tensor
    ```
    
    when `total_L` is not specified, the meta registration has a data-dependent output shape (based on `offsets[0][-1]`). Returning an unbacked SymInt here should work in theory, but traceable wrapper subclass support is missing in later code to handle deferred runtime asserts. This PR fixes this.
    
    [ghstack-poisoned]
    jbschlosser committed May 20, 2024
    Configuration menu
    Copy the full SHA
    0e11f1e View commit details
    Browse the repository at this point in the history
  2. Update on "Traceable wrapper subclass support for deferred runtime as…

    …serts"
    
    
    The padded dense -> jagged conversion op has the signature:
    ```
    _fbgemm_dense_to_jagged_forward(Tensor dense, Tensor[] offsets, SymInt? total_L=None) -> Tensor
    ```
    
    when `total_L` is not specified, the meta registration has a data-dependent output shape (based on `offsets[0][-1]`). Returning an unbacked SymInt here should work in theory, but traceable wrapper subclass support is missing in later code to handle deferred runtime asserts. This PR fixes this.
    
    [ghstack-poisoned]
    jbschlosser committed May 20, 2024
    Configuration menu
    Copy the full SHA
    471a2bc View commit details
    Browse the repository at this point in the history