[FSDP2] allow meta tensors during loading state dict and cpu offloading #126267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126267
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5eb2e7d with merge base c1dc8bb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
weifengpy
added a commit
that referenced
this pull request
May 15, 2024
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: c077e9e6ae7ae23c855eb0997e5da18120649919 Pull Request resolved: #126267
awgu
approved these changes
May 15, 2024
test/distributed/_composable/fsdp/test_fully_shard_state_dict.py
Outdated
Show resolved
Hide resolved
test/distributed/_composable/fsdp/test_fully_shard_state_dict.py
Outdated
Show resolved
Hide resolved
awgu
added
release notes: distributed (fsdp2)
…pu offloading" unit test: ``pytest test/distributed/_composable/fsdp/test_fully_shard_state_dict.py`` with meta init and cpu offloading, we have meta tensors after`model.load_state_dict(assign=True, strict=False)`. This PR avoided calling `.cpu` on meta tensors otherwise it's a runtime error cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
weifengpy
added a commit
that referenced
this pull request
May 15, 2024
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 002a35b0abf528b8a7327ce7762416f0e42efa13 Pull Request resolved: #126267
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
awgu
reviewed
May 15, 2024
| @@ -245,7 +245,7 @@ def _init_sharded_param(self, param: nn.Parameter, device: torch.device): | |||
| self.padded_sharded_param_size = padded_sharded_param.size() | |||
| if sharded_param.numel() > 0: | |||
| padded_sharded_param[: sharded_param.size(0)].copy_(sharded_param) | |||
| if self.offload_to_cpu: | |||
| if self.offload_to_cpu and not torch.empty(0).is_meta: | |||
There was a problem hiding this comment.
Suggested change
| if self.offload_to_cpu and not torch.empty(0).is_meta: | |
| if self.offload_to_cpu and not padded_sharded_param.is_meta: |
There was a problem hiding this comment.
resolving in #126305
pytorchmergebot
pushed a commit
that referenced
this pull request
May 15, 2024
support fully_shard(model_on_meta, cpu_offload) when fully_shard is placed outside of `torch.device("meta")`
Pull Request resolved: #126305
Approved by: https://github.com/awgu
ghstack dependencies: #126267
ZelboK
pushed a commit
to ZelboK/pytorch
that referenced
this pull request
May 19, 2024
…ng (pytorch#126267) unit test: ``pytest test/distributed/_composable/fsdp/test_fully_shard_state_dict.py`` with meta init and cpu offloading, we have meta tensors after`model.load_state_dict(assign=True, strict=False)`. This PR avoided calling `.cpu` on meta tensors otherwise it's a runtime error Pull Request resolved: pytorch#126267 Approved by: https://github.com/awgu
ZelboK
pushed a commit
to ZelboK/pytorch
that referenced
this pull request
May 19, 2024
support fully_shard(model_on_meta, cpu_offload) when fully_shard is placed outside of `torch.device("meta")`
Pull Request resolved: pytorch#126305
Approved by: https://github.com/awgu
ghstack dependencies: pytorch#126267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
unit test:
pytest test/distributed/_composable/fsdp/test_fully_shard_state_dict.pywith meta init and cpu offloading, we have meta tensors after
model.load_state_dict(assign=True, strict=False). This PR avoided calling.cpuon meta tensors otherwise it's a runtime errorcc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k