Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release only] Pin rocm docker images #126452

Merged
merged 5 commits into from
May 17, 2024

Conversation

atalman
Copy link
Contributor

@atalman atalman commented May 16, 2024

@atalman atalman requested a review from a team as a code owner May 16, 2024 20:57
Copy link

pytorch-bot bot commented May 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126452

Note: Links to docs will display an error until the docs builds have been completed.

❌ 36 New Failures, 1 Unrelated Failure

As of commit f85309d with merge base 86a2d67 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels May 16, 2024
@atalman atalman changed the title Pin rocm docker images [Release only] Pin rocm docker images May 17, 2024
@jithunnair-amd
Copy link
Collaborator

@atalman For the sake of posterity, can we elaborate a bit on why we need to pin the ROCm docker images for the release branch?

@atalman
Copy link
Contributor Author

atalman commented May 17, 2024

@jithunnair-amd This is general problem, we would need to pin all CI docker images - not only rocm builds. I will plan changes in main. This PR is to make all rocm jobs green by using same docker image used in CI for 2.3.0

@atalman atalman merged commit ee68b41 into pytorch:release/2.3 May 17, 2024
170 of 208 checks passed
@atalman atalman deleted the pin_rocm_docker branch May 17, 2024 17:43
atalman added a commit that referenced this pull request May 22, 2024
jithunnair-amd added a commit to ROCm/pytorch that referenced this pull request May 23, 2024
atalman pushed a commit that referenced this pull request May 23, 2024
…docker images (#126942)

* Update setting of journal_mode to delete

* Revert "[Release only] Pin rocm docker images (#126452)"

This reverts commit ee68b41.

* Replace tabs with spaces for lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/rocm module: rocm AMD GPU support for Pytorch topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants