Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitmodules: switch cpp-httplib to https #126580

Closed
wants to merge 1 commit into from
Closed

Conversation

d4l3k
Copy link
Collaborator

@d4l3k d4l3k commented May 17, 2024

Fixes issue introduced in #126470 (comment)

Test plan:

CI

@d4l3k d4l3k requested a review from PaliC May 17, 2024 22:38
Copy link

pytorch-bot bot commented May 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126580

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1e273ff with merge base d7de4c9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 17, 2024
@d4l3k d4l3k requested a review from jeffdaily May 17, 2024 22:38
@PaliC
Copy link
Contributor

PaliC commented May 17, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 17, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
@github-actions github-actions bot deleted the d4l3k/httplib-gitmodules branch June 17, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants