[SDPA/memeff] Backport changes from xFormers to PT #127090
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127090
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 791c0e9 with merge base f4d7cdc ( UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
danthe3rd
requested review from
albanD,
jbschlosser,
mikaylagawarecki and
soulitzer
as code owners
aten/src/ATen/native/transformers/cuda/mem_eff_attention/kernel_backward.h
Show resolved
Hide resolved
|
For the BC tests you need to update the list here: |
| return; | ||
| } | ||
| } | ||
|
|
||
| auto prologueGradV = [&](int col) { | ||
| typename MatmulGradV::Mma::IteratorB iterator_dO( | ||
| {int32_t(p.gO_strideM)}, |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchmergebot merge -f "Queuing CI jobs" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Backporting a few fixes from xFormers:
Essentially this will also make xFormers build process much easier, as we will be able to use mem-eff from PyTorch (if the user has a recent enough version) rather than building it at xFormers install time
The goal is to have the source of truth for these files in PT moving forward, and remove them from xFormers eventually once our users have a recent-enough version of PT.