Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPS] Include MPSGraphVenturaOps.h for complex types on macOS 12 #127859

Closed
wants to merge 3 commits into from
Closed

[MPS] Include MPSGraphVenturaOps.h for complex types on macOS 12 #127859

wants to merge 3 commits into from

Conversation

qqaatw
Copy link
Collaborator

@qqaatw qqaatw commented Jun 4, 2024 •
edited by pytorchmergebot
Loading

Stack from ghstack (oldest at bottom):

Fixes this on macOS 12:

/Users/qqaatw/Forks/pytorch/aten/src/ATen/native/mps/operations/FastFourierTransform.mm:108:60: error: use of undeclared identifier 'MPSDataTypeComplexFloat16'; did you mean 'MPSDataTypeFloat16'?
            (inputTensor.dataType == MPSDataTypeFloat16) ? MPSDataTypeComplexFloat16 : MPSDataTypeComplexFloat32;
                                                           ^~~~~~~~~~~~~~~~~~~~~~~~~
                                                           MPSDataTypeFloat16

@qqaatw
Update
b3fb336 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127859

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 40b6b82 with merge base 65aa16f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Jun 4, 2024
qqaatw added a commit that referenced this pull request Jun 4, 2024
@qqaatw
[MPS] Add complex types stub on macOS12
0cdd244 
ghstack-source-id: 342909e5e106827eaa348938d986f7c1f31c66a5
Pull Request resolved: #127859
@qqaatw qqaatw changed the title [MPS] Add complex types stub on macOS12 [MPS] Add complex types stub for macOS12 Jun 4, 2024
@qqaatw
Copy link
Collaborator Author

qqaatw commented Jun 4, 2024

@malfet looks like the failure is irrelevant.

@qqaatw qqaatw requested review from albanD June 5, 2024 00:36
@qqaatw
Copy link
Collaborator Author

qqaatw commented Jun 7, 2024

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 7, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@qqaatw
Update
f5fceb2 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/qqaatw/16/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/127859)

pytorchmergebot pushed a commit that referenced this pull request Jun 7, 2024
@qqaatw
[MPS] Add complex types stub on macOS12
d196c24 
ghstack-source-id: 28d1efdf89e3dc3dc9c60a39a634c3a3b2bcbadf
Pull Request resolved: #127859
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-14)

Details for Dev Infra team Raised by workflow job

@qqaatw
Update
40b6b82 
[ghstack-poisoned]
qqaatw added a commit that referenced this pull request Jun 7, 2024
@qqaatw
[MPS] Add complex types stub on macOS12
1a34171 
ghstack-source-id: 05a0730be85923fa9b2ea0f16f81b64be3074840
Pull Request resolved: #127859
@qqaatw qqaatw changed the title [MPS] Add complex types stub for macOS12 [MPS] Include MPSGraphVenturaOps.h for complex types on macOS 12 Jun 7, 2024
@qqaatw
Copy link
Collaborator Author

qqaatw commented Jun 7, 2024

It turned out that I only need to include MPSGraphVenturaOps.h.

@qqaatw
Copy link
Collaborator Author

qqaatw commented Jun 7, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
@qqaatw @TharinduRusira
[MPS] Include MPSGraphVenturaOps.h for complex types on macOS 12 (pyt…
5bf4e71 
…orch#127859)

Fixes this on macOS 12:

```
/Users/qqaatw/Forks/pytorch/aten/src/ATen/native/mps/operations/FastFourierTransform.mm:108:60: error: use of undeclared identifier 'MPSDataTypeComplexFloat16'; did you mean 'MPSDataTypeFloat16'?
            (inputTensor.dataType == MPSDataTypeFloat16) ? MPSDataTypeComplexFloat16 : MPSDataTypeComplexFloat32;
                                                           ^~~~~~~~~~~~~~~~~~~~~~~~~
                                                           MPSDataTypeFloat16
```

Pull Request resolved: pytorch#127859
Approved by: https://github.com/kulinseth
@github-actions github-actions bot deleted the gh/qqaatw/16/head branch July 8, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth kulinseth approved these changes

@malfet malfet Awaiting requested review from malfet

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qqaatw @pytorchmergebot @kulinseth @pytorchbot