Skip debug asserts for mixed dense, subclass views in autograd_not_implemented_fallback #128057
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plemented_fallback [ghstack-poisoned]
This was referenced Jun 5, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128057
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 30bf882 with merge base edb45dc ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 5, 2024
albanD
approved these changes
Jun 5, 2024
soulitzer
approved these changes
Jun 7, 2024
…grad_not_implemented_fallback" Fixes #125503 [ghstack-poisoned]
…grad_not_implemented_fallback" Fixes #125503 [ghstack-poisoned]
…grad_not_implemented_fallback" Fixes #125503 [ghstack-poisoned]
…grad_not_implemented_fallback" Fixes #125503 [ghstack-poisoned]
…grad_not_implemented_fallback" Fixes #125503 [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: Check mergeability of ghstack PR / ghstack-mergeability-check Details for Dev Infra teamRaised by workflow job |
…grad_not_implemented_fallback" Fixes #125503 [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
TharinduRusira
pushed a commit
to TharinduRusira/pytorch
that referenced
this pull request
Jun 14, 2024
…plemented_fallback (pytorch#128057) Fixes pytorch#125503 Pull Request resolved: pytorch#128057 Approved by: https://github.com/albanD, https://github.com/soulitzer ghstack dependencies: pytorch#127007
ignaciobartol
pushed a commit
to ignaciobartol/pytorch
that referenced
this pull request
Jun 14, 2024
…plemented_fallback (pytorch#128057) Fixes pytorch#125503 Pull Request resolved: pytorch#128057 Approved by: https://github.com/albanD, https://github.com/soulitzer ghstack dependencies: pytorch#127007
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 17, 2024
Idea: close over min / max sequence length in the main NJT view func (`_nested_view_from_jagged`) so that view replay during fake-ification propagates these correctly in torch.compile. For dynamic shapes support for min / max sequence length, this PR uses a hack that stores the values in `(val, 0)` shaped tensors. **NB: This PR changes SDPA to operate on real views instead of using `buffer_from_jagged()` / `ViewNestedFromBuffer`, which may impact the internal FIRST model. That is, it undoes the partial revert from #123215 alongside a fix to the problem that required the partial revert. We need to verify that there are no regressions there before landing.** Differential Revision: [D55448636](https://our.internmc.facebook.com/intern/diff/D55448636) Pull Request resolved: #122836 Approved by: https://github.com/soulitzer ghstack dependencies: #127007, #128057
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 18, 2024
francograndegmailcom
pushed a commit
to francograndegmailcom/pytorch-pytorch
that referenced
this pull request
Jul 23, 2024
…plemented_fallback ghstack-source-id: d3a6a41688bb4a7cb546b0bbdc68d546c92adb52 Pull Request resolved: pytorch/pytorch#128057
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #125503