Add decompositions for copy variants of view ops #128416
Open
+233
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
rec
requested review from
kulinseth,
malfet,
zou3519,
Chillee,
kshitij12345,
mruberry,
BowenBao,
thiagocrepaldi,
wschin,
albanD and
soulitzer
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128416
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 118 PendingAs of commit b5d251b with merge base 1e61cb8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
ciflow/mps
rec
added a commit
that referenced
this pull request
Jun 11, 2024
ghstack-source-id: a290ff22d81cdf09038063a6bd2b5c47e103b460 Pull Request resolved: #128416
rec
added a commit
to rec/pytorch
that referenced
this pull request
Jun 13, 2024
ghstack-source-id: a290ff22d81cdf09038063a6bd2b5c47e103b460 Pull Request resolved: pytorch#128416
rec
added a commit
to rec/pytorch
that referenced
this pull request
Jun 13, 2024
ghstack-source-id: a290ff22d81cdf09038063a6bd2b5c47e103b460 Pull Request resolved: pytorch#128416
rec
added a commit
to rec/pytorch
that referenced
this pull request
Jun 13, 2024
ghstack-source-id: a290ff22d81cdf09038063a6bd2b5c47e103b460 Pull Request resolved: pytorch#128416
rec
added a commit
to rec/pytorch
that referenced
this pull request
Jun 13, 2024
ghstack-source-id: a290ff22d81cdf09038063a6bd2b5c47e103b460 Pull Request resolved: pytorch#128416
[ghstack-poisoned]
rec
added a commit
that referenced
this pull request
Jun 13, 2024
ghstack-source-id: 32dce226e1e801cc8278a3dbe985e22d0292f039 Pull Request resolved: #128416
[ghstack-poisoned]
rec
added a commit
that referenced
this pull request
Jun 14, 2024
ghstack-source-id: 32dce226e1e801cc8278a3dbe985e22d0292f039 Pull Request resolved: #128416
[ghstack-poisoned]
rec
added a commit
that referenced
this pull request
Jul 3, 2024
ghstack-source-id: 8e4e90c06a7b861eec2ee10f0b0eee11496df8b2 Pull Request resolved: #128416
[ghstack-poisoned]
rec
added a commit
to rec/pytorch
that referenced
this pull request
Jul 4, 2024
ghstack-source-id: 8e4e90c06a7b861eec2ee10f0b0eee11496df8b2 Pull Request resolved: pytorch#128416
|
The single ❌ seems to be caused by the SEV, so this is ready to go. |
rec
added a commit
to rec/pytorch
that referenced
this pull request
Jul 4, 2024
ghstack-source-id: 8e4e90c06a7b861eec2ee10f0b0eee11496df8b2 Pull Request resolved: pytorch#128416
[ghstack-poisoned]
rec
added a commit
to rec/pytorch
that referenced
this pull request
Jul 4, 2024
ghstack-source-id: 90438a927c50ab4ab31c12e18f11846af0423723 Pull Request resolved: pytorch#128416
rec
added a commit
to rec/pytorch
that referenced
this pull request
Jul 4, 2024
ghstack-source-id: 90438a927c50ab4ab31c12e18f11846af0423723 Pull Request resolved: pytorch#128416
[ghstack-poisoned]
amjames
approved these changes
Jul 5, 2024
|
@pytorchbot: merge |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge |
Merge failedReason: Approvers from one of the following sets are needed:
|
cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab chauhang d4l3k voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire [ghstack-poisoned]
rec
added a commit
that referenced
this pull request
Jul 8, 2024
ghstack-source-id: 4eba26fa68813477bd7eb7620e23dd2c8bb1f413 Pull Request resolved: #128416
lezcano
reviewed
Jul 9, 2024
rec
added a commit
to rec/pytorch
that referenced
this pull request
Jul 9, 2024
ghstack-source-id: 4eba26fa68813477bd7eb7620e23dd2c8bb1f413 Pull Request resolved: pytorch#128416
cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab chauhang d4l3k voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire [ghstack-poisoned]
rec
added a commit
that referenced
this pull request
Jul 9, 2024
ghstack-source-id: 3053377639c5a5bcf864bf8e13aa298b10b053e0 Pull Request resolved: #128416
lezcano
reviewed
Jul 9, 2024
torch/_prims_common/wrappers.py
Outdated
Comment on lines
322
to
323
| params = *sig.parameters.values(), out_param | ||
| params = sorted(params, key=lambda p: p.kind) |
There was a problem hiding this comment.
Why is this change necessary?
There was a problem hiding this comment.
Without that line, if there's a **kwds parameter, it's placed before the out= parameter, and you get an exception ValueError: wrong parameter order: variadic keyword parameter before keyword-only parameter.
I added a comment to this effect.
torch/_prims_common/wrappers.py
Outdated
|
|
||
| from typing import Callable, NamedTuple, Optional, overload, Sequence, Tuple | ||
| from typing import Callable, Dict, NamedTuple, Optional, overload, Sequence, Tuple |
There was a problem hiding this comment.
Suggested change
| from typing import Callable, Dict, NamedTuple, Optional, overload, Sequence, Tuple | |
| from typing import Callable, NamedTuple, Optional, overload, Sequence, Tuple |
torch/_refs/__init__.py
Outdated
| aten_fn = getattr(aten, fn.__name__) | ||
| annotations = fn.__annotations__ | ||
| fn = out_wrapper()(aten_fn) | ||
| fn.__annotations__.update(annotations) |
There was a problem hiding this comment.
nit. Move it to after _fn.__name__ to keep all the metaprogramming together.
rec
added a commit
to rec/pytorch
that referenced
this pull request
Jul 9, 2024
ghstack-source-id: 3053377639c5a5bcf864bf8e13aa298b10b053e0 Pull Request resolved: pytorch#128416
cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab chauhang d4l3k voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire [ghstack-poisoned]
rec
added a commit
that referenced
this pull request
Jul 9, 2024
ghstack-source-id: ac370ec2fd6d0dffe0e79a6a24b836af869f05d1 Pull Request resolved: #128416
Nits are good to find - they decrease the difficulty of the code for the next programmer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @chauhang @d4l3k @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire