Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] Use AOTriton as a dynamic library #129094

Closed
wants to merge 3 commits into from
Closed

[ROCm] Use AOTriton as a dynamic library #129094

wants to merge 3 commits into from

Conversation

jithunnair-amd
Copy link
Collaborator

@jithunnair-amd jithunnair-amd commented Jun 19, 2024 •
edited
Loading

This PR enables using AOTriton as a shared library dependency instead of a static one.

Resolves the issue of linker errors when trying to build PyTorch for a lot of (>7 or so) gfx archs due to huge size of aotriton static library.

cc @jeffdaily @sunway513 @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @groenenboomj @xinyazhang

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 19, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129094

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit d2ae2ea with merge base 74e11a4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm module: rocm AMD GPU support for Pytorch labels Jun 19, 2024
@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Jun 27, 2024
@jithunnair-amd jithunnair-amd mentioned this pull request Jun 27, 2024
Merged
@jithunnair-amd jithunnair-amd marked this pull request as ready for review June 27, 2024 20:43
@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 27, 2024
@jithunnair-amd jithunnair-amd added the rocm This tag is for PRs from ROCm team label Jul 1, 2024
@malfet
Copy link
Contributor

malfet commented Jul 1, 2024

@pytorchbot merge -f "Pull was never triggered for this PR somehow"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit to khushi-411/pytorch that referenced this pull request Jul 2, 2024
@jithunnair-amd @pytorchmergebot
[ROCm] Use AOTriton as a dynamic library (pytorch#129094)
ea86255 
This PR enables using AOTriton as a shared library dependency instead of a static one.

Resolves the issue of linker errors when trying to build PyTorch for a lot of (>7 or so) gfx archs due to huge size of aotriton static library.

Pull Request resolved: pytorch#129094
Approved by: https://github.com/malfet
@jithunnair-amd jithunnair-amd deleted the aotriton_shared_object branch July 3, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees
No one assigned
Labels
ciflow/rocm Merged module: rocm AMD GPU support for Pytorch open source release notes: releng release notes category rocm This tag is for PRs from ROCm team triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jithunnair-amd @malfet @pytorchmergebot @colesbury @pytorchbot